Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libphoenix: rename dirs in include/arch and crt0 files #319

Merged
merged 1 commit into from
Dec 15, 2023
Merged

libphoenix: rename dirs in include/arch and crt0 files #319

merged 1 commit into from
Dec 15, 2023

Conversation

badochov
Copy link
Contributor

JIRA: RTOS-664

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

github-actions[bot]
github-actions bot reviewed Dec 10, 2023
View reviewed changes
include/arch/armv7a/arch.h Outdated Show resolved Hide resolved
include/arch/armv7m/arch.h Outdated Show resolved Hide resolved
@badochov badochov force-pushed the badochov/build branch 2 times, most recently from 9c955e9 to 9694d0e Compare December 10, 2023 21:46
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 10, 2023 •
edited
Loading

Unit Test Results

6 002 tests  ±0   5 368 ✔️ ±0   30m 42s ⏱️ + 1m 30s
   346 suites ±0      634 💤 ±0 
       1 files   ±0          0 ❌ ±0 

Results for commit 33c6907. ± Comparison against base commit bfb6d46.

♻️ This comment has been updated with latest results.

@badochov badochov force-pushed the badochov/build branch 3 times, most recently from b8dfba5 to d8d4ed6 Compare December 11, 2023 12:45
@badochov badochov changed the title libphoenix: rename dirs in include/arch to match those in arch libphoenix: rename dirs in include/arch and crt0 files Dec 11, 2023
@badochov
libphoenix: rename dirs in include/arch and crt0 files
33c6907 
Rename crt0 files to crt0-common.c and crt0.S.
Change dir names in include/arch from arm-imx and armv7 to armv7a and
armv7m respectively, to match names in arch directory.

JIRA: RTOS-712
agkaminski
agkaminski approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@agkaminski agkaminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@badochov badochov merged commit 9d138b9 into master Dec 15, 2023
30 checks passed
@badochov badochov deleted the badochov/build branch December 15, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions GitHub Actions left review comments

@agkaminski agkaminski agkaminski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@badochov @agkaminski