stdio/file: fix numerous issues in the fread/fwrite functions #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixed error handling in blocking safe read to always return -1 on error. JIRA: RTOS-892, RTOS-874
Fixed fread function issues: - non-blocking fread was not supported - unbuffered read was not setting F_ERROR on read errors - unbuffered read was not setting F_EOF at the end-of-file - unbuffered read was dropping bytes on EAGAIN - buffered read was not setting F_ERROR when refilling the buffer - buffered read was dropping bytes on EAGAIN - buffered read was incorrectly setting F_EOF on EAGAIN Fixed fwrite function issues: - interleaved fread/fwrite functions weren't working for Unix sockets (caused by an unnecessary seek trigerring an error) - fwrite was returning 0 when read buffer discarding failed due to seek errors JIRA: RTOS-892
ziemleszcz
force-pushed
the
ziemleszcz/RTOS-892
branch
from
bf2a36e
to
7058c9c
Compare
14 tasks
ziemleszcz
changed the title
Darchiv
reviewed
Sep 23, 2024
| @@ -101,18 +101,26 @@ ssize_t __safe_read(int fd, void *buf, size_t size) | |||
| continue; | |||
| } | |||
| else { | |||
| break; | |||
| return -1; | |||
There was a problem hiding this comment.
Also fixed error handling in blocking safe read to always return -1 on error.
How is this different? The else branch is taken when rlen < 0, so if (rlen < 0) below is still executed.
There was a problem hiding this comment.
You're right - disregard this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Types of changes
How Has This Been Tested?
Checklist:
Special treatment