Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add globally defined __TARGET and __CPU to phoenix-rtos-build #145

Merged
merged 2 commits into from
Jul 12, 2023

Conversation

gerard5
Copy link
Contributor

@gerard5 gerard5 commented Jul 12, 2023

Description

Adds globally visible defines (through C/XXFLAGS) pointing to TARGET architecture and CPU. The definitions are derived from TARGET_FAMILY and TARGET_SUBFAMILY.

Motivation and Context

Need of include target specific headers in phoenix-rtos-devices, libphoenix, etc.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: imxrt1176-nil, ia32-generic.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@gerard5 gerard5 marked this pull request as ready for review July 12, 2023 12:18
@gerard5 gerard5 self-assigned this Jul 12, 2023
nalajcie
nalajcie previously approved these changes Jul 12, 2023
Copy link
Member

@nalajcie nalajcie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small thing worth consideration (not sure which is better, use whatever version you would like).

I'm assuming the currently-existing defines like KERNEL_TARGET_DEFINE=-DCPU_IMXRT106X -DNOMMU would be removed in separate PR after necessary changes in submodules.

agkaminski
agkaminski previously approved these changes Jul 12, 2023
makes/funcs.mk Outdated Show resolved Hide resolved
Adds globally visible defines pointing to TARGET architecture
and CPU. The definitions are derived from TARGET_FAMILY and
TARGET_SUBFAMILY.

JIRA: RTOS-519
@gerard5 gerard5 merged commit bee0184 into master Jul 12, 2023
24 checks passed
@gerard5 gerard5 deleted the gerard5/RTOS-519 branch July 12, 2023 14:39
@gerard5
Copy link
Contributor Author

gerard5 commented Jul 14, 2023

one small thing worth consideration (not sure which is better, use whatever version you would like).

I'm assuming the currently-existing defines like KERNEL_TARGET_DEFINE=-DCPU_IMXRT106X -DNOMMU would be removed in separate PR after necessary changes in submodules.

#146 Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants