Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate build options. #147

Merged
merged 1 commit into from
Jul 19, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
# It can be overwritten by build.project scripts.
ROOTFS_OVERLAYS=""

. ./phoenix-rtos-build/build.subr

Check warning on line 17 in build.sh

View workflow job for this annotation

GitHub Actions / call-lint / shellcheck-pr

[shellcheck] reported by reviewdog 🐶 Not following: ./phoenix-rtos-build/build.subr: openBinaryFile: does not exist (No such file or directory) [SC1091](https://github.com/koalaman/shellcheck/wiki/SC1091) Raw Output: ./build.sh:17:3:info:Not following: ./phoenix-rtos-build/build.subr: openBinaryFile: does not exist (No such file or directory) [SC1091](https://github.com/koalaman/shellcheck/wiki/SC1091)
. ./build.project

Check warning on line 18 in build.sh

View workflow job for this annotation

GitHub Actions / call-lint / shellcheck-pr

[shellcheck] reported by reviewdog 🐶 Not following: ./build.project: openBinaryFile: does not exist (No such file or directory) [SC1091](https://github.com/koalaman/shellcheck/wiki/SC1091) Raw Output: ./build.sh:18:3:info:Not following: ./build.project: openBinaryFile: does not exist (No such file or directory) [SC1091](https://github.com/koalaman/shellcheck/wiki/SC1091)

PREFIX_PROJECT="$(pwd)"
# TODO: Remove
Expand Down Expand Up @@ -51,7 +51,7 @@
AS=${CROSS}as
LD=${CROSS}ld
AR=${CROSS}ar
OBJCPY=${CROSS}objcopy

Check warning on line 54 in build.sh

View workflow job for this annotation

GitHub Actions / call-lint / shellcheck-pr

[shellcheck] reported by reviewdog 🐶 OBJCPY appears unused. Verify use (or export if used externally). [SC2034](https://github.com/koalaman/shellcheck/wiki/SC2034) Raw Output: ./build.sh:54:1:warning:OBJCPY appears unused. Verify use (or export if used externally). [SC2034](https://github.com/koalaman/shellcheck/wiki/SC2034)

MAKEFLAGS="--no-print-directory -j 9"

Expand Down Expand Up @@ -87,8 +87,8 @@
ARGS=("$@")
[ "$#" -eq 1 ] && read -ra ARGS <<< "$1"

for i in "${ARGS[@]}"; do
case "$i"
for arg in "${ARGS[@]}"; do
case "$arg"
in
clean)
CLEAN="clean";;
Expand All @@ -106,6 +106,9 @@
B_IMAGE="y";;
all)
B_FS="y"; B_CORE="y"; B_PORTS="y"; B_PROJECT="y"; B_IMAGE="y";;
*)
echo "Unknown build option: \"$arg\"."
exit 1;;
esac;
done

Expand Down
Loading