Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make: Add passing WATCHDOG as define #163

Merged
merged 1 commit into from
Sep 27, 2023
Merged

make: Add passing WATCHDOG as define #163

merged 1 commit into from
Sep 27, 2023

Conversation

anglov
Copy link
Member

@anglov anglov commented Sep 19, 2023 •
edited
Loading

JIRA: DEND-32 DTR-408

Description

This change enable possibility to pass WATCHDOG to kernel/plo build

Motivation and Context

While we want to deprecate BOARD_CONFIG env, we need to find a way to pass watchdog setting to kernel/plo. Decided to do so via env which is defaultly enabled. Need to be disabled directly when not wanted.
Also it enables WATCHDOG on armv7a7-imx6ull

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Application to handle watchdog needed if watchdog wasn't enabled before. Alternatively - disable watchdog explicitly

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: armv7m4-stm32l4x6-nucleo.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

@github-actions
Copy link

github-actions bot commented Sep 19, 2023 •
edited
Loading

Unit Test Results

5 721 tests  ±0   5 076 ✔️ ±0   24m 18s ⏱️ -44s
   290 suites ±0      645 💤 ±0 
       1 files   ±0          0 ❌ ±0 

Results for commit d4497c5. ± Comparison against base commit c7b9f62.

♻️ This comment has been updated with latest results.

@anglov anglov changed the title make: Add passing TOOLCHAIN as define make: Add passing WATCHDOG as define Sep 19, 2023
@anglov anglov mentioned this pull request Sep 19, 2023
Merged
13 tasks
@anglov anglov marked this pull request as ready for review September 19, 2023 15:07
nalajcie
nalajcie reviewed Sep 20, 2023
View reviewed changes
Makefile.common Outdated Show resolved Hide resolved
nalajcie
nalajcie reviewed Sep 20, 2023
View reviewed changes
Makefile.common Outdated Show resolved Hide resolved
@anglov
make: Passing WATCHDOG as define
d4497c5 
Current behavior is:
WATCHDOG is enabled by default
When DEBUG is enabled, WATCHDOG is disabled by default
Both behavior can be overwritten by passing WATCHDOG=1 env/variable

JIRA: DEND-32 DTR-408
This was referenced Sep 21, 2023
Merged
Merged
agkaminski
agkaminski approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@agkaminski agkaminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anglov anglov merged commit 72fc581 into master Sep 27, 2023
30 checks passed
@anglov anglov deleted the anglov/watchdog branch September 27, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerard5 gerard5 gerard5 approved these changes

@nalajcie nalajcie nalajcie approved these changes

@agkaminski agkaminski agkaminski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anglov @gerard5 @nalajcie @agkaminski