Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

!toolchain: update binutils to 2.43 #203

Merged
merged 2 commits into from
Oct 2, 2024
Merged

!toolchain: update binutils to 2.43 #203

merged 2 commits into from
Oct 2, 2024

Conversation

badochov
Copy link
Contributor

@badochov badochov commented Sep 10, 2024 •
edited
Loading

Description

Binutils 2.39 introduced two new warning more info here: https://www.redhat.com/en/blog/linkers-warnings-about-executable-stacks-and-segments
Thus patches in plo and build are needed.

Motivation and Context

Binutils had a bug till 2.37 in generating thumb on arm v8m-base.
Updating to newer binutils can lead to mergin our patches to binutils upstream.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 10, 2024 •
edited
Loading

Unit Test Results

7 723 tests  ±0   7 008 ✅ ±0   38m 32s ⏱️ -19s
  443 suites ±0     715 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit c9f70a2. ± Comparison against base commit 2dc9570.

♻️ This comment has been updated with latest results.

@badochov badochov force-pushed the badochov/binutils-2.43 branch 2 times, most recently from 482891e to fab16cc Compare September 10, 2024 15:19
@badochov
Copy link
Contributor Author

badochov commented Sep 10, 2024 •
edited
Loading

Demo: phoenix-rtos/phoenix-rtos-project#1161

@badochov badochov force-pushed the badochov/binutils-2.43 branch 2 times, most recently from 68a509d to 6f1c7ae Compare September 11, 2024 09:47
@badochov badochov changed the title feat(toolchain): update binutils to 2.43 !toolchain: update binutils to 2.43 Sep 11, 2024
@badochov badochov marked this pull request as ready for review September 11, 2024 09:47
@badochov badochov mentioned this pull request Sep 11, 2024
Closed
14 tasks
@badochov badochov force-pushed the badochov/binutils-2.43 branch 4 times, most recently from 29e6603 to 93ac2fa Compare September 17, 2024 14:00
Darchiv
Darchiv previously approved these changes Sep 30, 2024
View reviewed changes
@badochov badochov dismissed Darchiv’s stale review October 2, 2024 09:56

The merge-base changed after approval.

@badochov badochov requested a review from Darchiv October 2, 2024 09:57
@badochov badochov merged commit 4183f39 into master Oct 2, 2024
34 checks passed
@badochov badochov deleted the badochov/binutils-2.43 branch October 2, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darchiv Darchiv Darchiv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@badochov @Darchiv