stm32-multi: rtc: add functionality for subseconds #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
multi/stm32l4-multi/rtc.c
Outdated
Comment on lines
145
to
147
| const unsigned int month_days[12] = {31, 28, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31}; | ||
|
|
||
| timestamp->usecs = ((uint64_t) (rtc_common.prediv_s - (ssec & 0xffff)) * 1000 * 1000) / (rtc_common.prediv_s + 1); |
There was a problem hiding this comment.
[clang-format-pr] reported by reviewdog 🐶
suggested fix
Suggested change
| const unsigned int month_days[12] = {31, 28, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31}; | |
| timestamp->usecs = ((uint64_t) (rtc_common.prediv_s - (ssec & 0xffff)) * 1000 * 1000) / (rtc_common.prediv_s + 1); | |
| const unsigned int month_days[12] = { 31, 28, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31 }; | |
| timestamp->usecs = ((uint64_t)(rtc_common.prediv_s - (ssec & 0xffff)) * 1000 * 1000) / (rtc_common.prediv_s + 1); |
multi/stm32l4-multi/rtc.c
Outdated
| timestamp->usecs = ((uint64_t) (rtc_common.prediv_s - (ssec & 0xffff)) * 1000 * 1000) / (rtc_common.prediv_s + 1); | ||
|
|
||
| if (ssec > rtc_common.prediv_s) { | ||
| timestamp->usecs = ((uint64_t) (2 * rtc_common.prediv_s - (ssec & 0xffff)) * 1000 * 1000) / (rtc_common.prediv_s + 1); |
There was a problem hiding this comment.
[clang-format-pr] reported by reviewdog 🐶
suggested fix
Suggested change
| timestamp->usecs = ((uint64_t) (2 * rtc_common.prediv_s - (ssec & 0xffff)) * 1000 * 1000) / (rtc_common.prediv_s + 1); | |
| timestamp->usecs = ((uint64_t)(2 * rtc_common.prediv_s - (ssec & 0xffff)) * 1000 * 1000) / (rtc_common.prediv_s + 1); |
multi/stm32l4-multi/rtc.c
Outdated
| else { | ||
| timestamp->hours = (24 + timestamp->hours - carry) % 24; | ||
| } | ||
|
|
There was a problem hiding this comment.
[clang-format-pr] reported by reviewdog 🐶
suggested fix
Suggested change
multi/stm32l4-multi/rtc.c
Outdated
| prev_month = (11 + timestamp->month) % 12; | ||
| prev_month_days = month_days[prev_month]; | ||
| if (prev_month == 2 && ((timestamp->year % 4 == 0 && timestamp->year % 100 != 0) || timestamp->year % 400 == 0)) { | ||
| prev_month_days ++; |
There was a problem hiding this comment.
[clang-format-pr] reported by reviewdog 🐶
suggested fix
Suggested change
| prev_month_days ++; | |
| prev_month_days++; |
multi/stm32l4-multi/rtc.c
Outdated
| } | ||
| else { | ||
| timestamp->month = (12 + timestamp->month - carry) % 12; | ||
| } |
There was a problem hiding this comment.
[clang-format-pr] reported by reviewdog 🐶
suggested fix
Suggested change
| } | |
| } |
multi/stm32l4-multi/rtc.c
Outdated
Comment on lines
251
to
252
| ssec = *(rtc_common.base + ssr) & 0xffff; | ||
| ssec = ((uint64_t) (rtc_common.prediv_s - ssec) * 1000 * 1000) / (rtc_common.prediv_s + 1); |
There was a problem hiding this comment.
[clang-format-pr] reported by reviewdog 🐶
suggested fix
Suggested change
| ssec = *(rtc_common.base + ssr) & 0xffff; | |
| ssec = ((uint64_t) (rtc_common.prediv_s - ssec) * 1000 * 1000) / (rtc_common.prediv_s + 1); | |
| ssec = *(rtc_common.base + ssr) & 0xffff; | |
| ssec = ((uint64_t)(rtc_common.prediv_s - ssec) * 1000 * 1000) / (rtc_common.prediv_s + 1); |
multi/stm32l4-multi/rtc.c
Outdated
| ssec = *(rtc_common.base + ssr) & 0xffff; | ||
| ssec = ((uint64_t) (rtc_common.prediv_s - ssec) * 1000 * 1000) / (rtc_common.prediv_s + 1); | ||
| /*Setting TR has a side effect of changing SSR value to prediv_s*/ | ||
| *(rtc_common.base + tr) = time; |
There was a problem hiding this comment.
[clang-format-pr] reported by reviewdog 🐶
suggested fix
Suggested change
| *(rtc_common.base + tr) = time; | |
| *(rtc_common.base + tr) = time; |
multi/stm32l4-multi/rtc.c
Outdated
| *(rtc_common.base + isr) &= ~(1 << 7); | ||
| while ((*(rtc_common.base + isr) & (1 << 3))); |
There was a problem hiding this comment.
[clang-format-pr] reported by reviewdog 🐶
suggested fix
Suggested change
| while ((*(rtc_common.base + isr) & (1 << 3))); | |
| while ((*(rtc_common.base + isr) & (1 << 3))) | |
| ; |
multi/stm32l4-multi/rtc.c
Outdated
| *(rtc_common.base + isr) &= ~(1 << 7); | ||
| while ((*(rtc_common.base + isr) & (1 << 3))); | ||
| *(rtc_common.base + shiftr) = ((1000 * 1000 - timestamp->usecs) * (rtc_common.prediv_s + 1) / (1000 * 1000)) | (1 << 31); | ||
| while ((*(rtc_common.base + isr) & (1 << 3))); |
There was a problem hiding this comment.
[clang-format-pr] reported by reviewdog 🐶
suggested fix
Suggested change
| while ((*(rtc_common.base + isr) & (1 << 3))); | |
| while ((*(rtc_common.base + isr) & (1 << 3))) | |
| ; |
pskiers
force-pushed
the
pskiers/stm32rtc
branch
from
1b08ad4
to
4bd887a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds functionality for rtc for subseconds
Description
Motivation and Context
Types of changes
How Has This Been Tested?
Checklist:
Special treatment