Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ad7779: apply a sync pulse after configuration #303

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jsarzy
Copy link
Contributor

@jsarzy jsarzy commented Oct 6, 2022

Description

Use a START pulse to generate an internal SYNC_IN pulse after each configuration. Additionaly, I removed the START pulse and long sleeps after device reboot. I have tested this on imx6ull and imxrt based architectures and it seems to work well. Hang-ups do not occur.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: imx6ull, imxrt106x.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

adc/ad7779/ad7779.c Outdated Show resolved Hide resolved
adc/ad7779/ad7779.c Outdated Show resolved Hide resolved
adc/ad7779/ad7779.c Outdated Show resolved Hide resolved
continue;
}

if ((status[16] & INIT_COMPLETE_BIT) && (status[13] & RESET_DETECTED_BIT)) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps a less error-prone and more readable approach would be to use a struct with fields instead the array with magic indices.

@jsarzy jsarzy marked this pull request as ready for review October 6, 2022 11:54
@jsarzy jsarzy requested a review from nalajcie October 6, 2022 11:55
adc/ad7779/ad7779.c Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants