imxrt-multi: add support for console over RTT #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHange implements library for RTT (multichannel, bidirectional) communicaton over debug probe JTAG/SWD. JIRA: RTOS-754
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
multi/imxrt-multi/rttuart.c
Outdated
| ret = (ret == 0) ? rtt_initChannel(1, chn, buf, RTT_TX_BUF_SIZE) : ret; | ||
| ret = (ret == 0) ? rtt_initChannel(0, chn, buf + RTT_TX_BUF_SIZE, RTT_RX_BUF_SIZE) : ret; | ||
| ret = (ret == 0) ? mutexCreate(&uart->lock) : ret; | ||
| /* TODO: cacluate approx. baud rate based on buffer size and polling rate */ |
There was a problem hiding this comment.
[codespell] reported by reviewdog 🐶
cacluate ==> calculate
jmaksymowicz
force-pushed
the
gerard5/RTOS-754
branch
from
c3b208b
to
03786ff
Compare
multi/imxrt-multi/rttuart.c
Outdated
| ret = (ret == 0) ? rtt_initChannel(1, chn, buf, RTT_TX_BUF_SIZE) : ret; | ||
| ret = (ret == 0) ? rtt_initChannel(0, chn, buf + RTT_TX_BUF_SIZE, RTT_RX_BUF_SIZE) : ret; | ||
| ret = (ret == 0) ? mutexCreate(&uart->lock) : ret; | ||
| /* TODO: calcuate approx. baud rate based on buffer size and polling rate */ |
There was a problem hiding this comment.
[codespell] reported by reviewdog 🐶
calcuate ==> calculate
Unit Test Results7 723 tests +23 7 008 ✅ +23 37m 14s ⏱️ - 1m 48s Results for commit f5e6b4d. ± Comparison against base commit 10cca0a. This pull request removes 1 and adds 24 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Darchiv
reviewed
Sep 13, 2024
jmaksymowicz
force-pushed
the
gerard5/RTOS-754
branch
2 times, most recently
from
f2d1e7e
to
9dcc4ef
Compare
jmaksymowicz
force-pushed
the
gerard5/RTOS-754
branch
from
9dcc4ef
to
05e9866
Compare
Darchiv
reviewed
Sep 26, 2024
Fix rtt structure read before initialization Add better argument validation Add volatile modifier where necessary Add option to use cached memory for buffers Renamed files and functions from "rtt" to "librtt" JIRA: RTOS-754
Add more utility functions to probe channel status. JIRA: RTOS-754
JIRA: RTOS-754
jmaksymowicz
force-pushed
the
gerard5/RTOS-754
branch
from
133fd0e
to
543908c
Compare
Darchiv
reviewed
Sep 27, 2024
Remove hard-coded RTT address and get it from memory map. Change RTT initialization to keep existing buffer contents if buffers are valid. Allow more channels in the control block than defined at compile time (they will not be usable by the userspace driver). JIRA: RTOS-754
JIRA: RTOS-754
jmaksymowicz
force-pushed
the
gerard5/RTOS-754
branch
from
543908c
to
3af1373
Compare
JIRA: RTOS-754
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for UART-like devices to be created which transmit data over RTT.
Description
Console can be defined to use either UART (as before) or an RTT channel. For now it is not possible to have console through both UART and RTT.
Each RTT channel can be configured to work in non-blocking or blocking mode. In non-blocking mode data is discarded if there is no space left in the buffer. In blocking mode the code attempts to detect if there is a host receiving data over the RTT interface and if there is, the code waits a pre-defined period until there is space left in the buffer.
Motivation and Context
With this change it is possible to access console (e.g.
psh) over RTT interface.Types of changes
How Has This Been Tested?
Checklist:
Special treatment