-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
languagetool: disable specific rules #158
Conversation
709000c
to
d96fdde
Compare
d96fdde
to
9f7607c
Compare
42c9b8f
to
4486f1b
Compare
99fa0fe
to
e03126e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we discussed let's leave LC_AFTER_PERIOD and DATE_WEEKDAY_WITHOUT_YEAR
e03126e
to
18822f9
Compare
small note: please use imperative mood in commit messages ( Worth considering: most of the issues stem from markdown code blocks being checked as native text - the ideal solution would be to make languagetool NOT check the code blocks at all (that way we could keep the rules enabled for native text). From quick research - I haven't found out-of-the box solution for it, but it probably could be done by LanguageTool API (so, writing our custom languagetool-based checker) and using it in CI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please correct commit messages and leave the mentioned comment (or sth similar) - IMHO we can merge it for now.
18822f9
to
e10363a
Compare
4ab49d6
to
c375bc6
Compare
JIRA CI-318
c375bc6
to
87e2230
Compare
JIRA CI-318
87e2230
to
1f9df7e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Disabled rules:
Examples why it's needed to disabled them:
ENGLISH_WORD_REPEAT_RULE :
RB_RB_COMMA[3]:
REP_PASSIVE_VOICE[6]:
AI[1]:
ID_CASING[2]:
ENGLISH_WORD_REPEAT_BEGINNING_RULE:
EN_UNPAIRED_BRACKETS: