Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lseek: Pass resulting offset via a pointer #482

Merged
merged 1 commit into from
Nov 30, 2023
Merged

lseek: Pass resulting offset via a pointer #482

merged 1 commit into from
Nov 30, 2023

Conversation

agkaminski
Copy link
Member

@agkaminski agkaminski commented Nov 30, 2023 •
edited
Loading

Fix behaviour on resulting negative file offset

JIRA: RTOS-397

Description

Fixes phoenix-rtos/phoenix-rtos-project#361
tested in phoenix-rtos/phoenix-rtos-project#939

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (ia32).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

@agkaminski
lseek: Pass resulting offset via a pointer
ea873f3 
Fix behaviour on resulting negative file offset

JIRA: RTOS-397
lukileczo
lukileczo approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@lukileczo lukileczo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agkaminski agkaminski merged commit f4edf1f into master Nov 30, 2023
21 of 29 checks passed
@agkaminski agkaminski deleted the agkaminski/rtos-397 branch November 30, 2023 11:37
@nalajcie
Copy link
Member

this is ABI breaking change, please mark it clearly next time in the commit message!

@lukileczo lukileczo mentioned this pull request Jan 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukileczo lukileczo lukileczo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

libphoenix/kernel: lseek() error with negative offset + strange errno
3 participants
@agkaminski @nalajcie @lukileczo