Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

posix: fix unix socket accept/connect, add their nonblocking variants, handle MSG_PEEK in recv #572

Merged
merged 2 commits into from
Sep 6, 2024
Merged

posix: fix unix socket accept/connect, add their nonblocking variants, handle MSG_PEEK in recv #572

merged 2 commits into from
Sep 6, 2024

Conversation

adamgreloch
Copy link
Member

JIRA: RTOS-877

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@adamgreloch adamgreloch mentioned this pull request Aug 1, 2024
Open
14 tasks
agkaminski
agkaminski reviewed Aug 1, 2024
View reviewed changes
posix/unix.c Outdated Show resolved Hide resolved
posix/unix.c Outdated

err = EOK;
if (s->state & US_PEER_CLOSED)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls take a look at https://docs.phoenix-rtos.com/coding/index.html

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, sorry. Corrected.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 1, 2024 •
edited
Loading

Unit Test Results

7 700 tests  ±0   6 985 ✅ ±0   38m 45s ⏱️ -11s
  436 suites ±0     715 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 76174bc. ± Comparison against base commit 2a3f1d1.

♻️ This comment has been updated with latest results.

@adamgreloch adamgreloch force-pushed the adamgreloch/RTOS-877 branch 2 times, most recently from fc26e1a to 9b9abcf Compare August 1, 2024 12:22
@adamgreloch adamgreloch marked this pull request as ready for review August 1, 2024 12:25
ziemleszcz
ziemleszcz reviewed Aug 2, 2024
View reviewed changes
posix/unix.c Outdated Show resolved Hide resolved
posix/unix.c Outdated Show resolved Hide resolved
@adamgreloch adamgreloch mentioned this pull request Aug 2, 2024
Open
14 tasks
ziemleszcz
ziemleszcz reviewed Aug 2, 2024
View reviewed changes
posix/unix.c Outdated Show resolved Hide resolved
posix/unix.c Show resolved Hide resolved
posix/unix.c Outdated Show resolved Hide resolved
posix/unix.c Show resolved Hide resolved
ziemleszcz
ziemleszcz reviewed Aug 5, 2024
View reviewed changes
posix/unix.c Outdated Show resolved Hide resolved
posix/unix.c Outdated Show resolved Hide resolved
posix/unix.c Outdated Show resolved Hide resolved
posix/unix.c Outdated Show resolved Hide resolved
posix/unix.c Outdated Show resolved Hide resolved
@adamgreloch adamgreloch force-pushed the adamgreloch/RTOS-877 branch 2 times, most recently from e371afc to 9eb663f Compare August 5, 2024 11:32
@Darchiv Darchiv self-requested a review August 12, 2024 13:27
ziemleszcz
ziemleszcz reviewed Aug 19, 2024
View reviewed changes
lib/cbuffer.c Outdated Show resolved Hide resolved
posix/unix.c Outdated Show resolved Hide resolved
ziemleszcz
ziemleszcz reviewed Aug 22, 2024
View reviewed changes
posix/unix.c Show resolved Hide resolved
posix/unix.c Outdated Show resolved Hide resolved
ziemleszcz
ziemleszcz reviewed Aug 23, 2024
View reviewed changes
posix/unix.c Outdated Show resolved Hide resolved
lib/cbuffer.h Outdated Show resolved Hide resolved
posix/unix.c Outdated Show resolved Hide resolved
posix/unix.c Outdated Show resolved Hide resolved
@adamgreloch adamgreloch mentioned this pull request Aug 26, 2024
Merged
14 tasks
ziemleszcz
ziemleszcz reviewed Sep 4, 2024
View reviewed changes
posix/unix.c Outdated Show resolved Hide resolved
posix/unix.c Outdated Show resolved Hide resolved
posix/unix.c Outdated Show resolved Hide resolved
posix/unix.c Outdated Show resolved Hide resolved
posix/unix.c Outdated Show resolved Hide resolved
posix/unix.c Outdated Show resolved Hide resolved
posix/unix.c Outdated Show resolved Hide resolved
posix/unix.c Outdated Show resolved Hide resolved
ziemleszcz
ziemleszcz approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@ziemleszcz ziemleszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ziemleszcz ziemleszcz merged commit ca23837 into master Sep 6, 2024
30 checks passed
@ziemleszcz ziemleszcz deleted the adamgreloch/RTOS-877 branch September 6, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agkaminski agkaminski agkaminski left review comments

@lukileczo lukileczo lukileczo left review comments

@ziemleszcz ziemleszcz ziemleszcz approved these changes

@Darchiv Darchiv Awaiting requested review from Darchiv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adamgreloch @ziemleszcz @agkaminski @lukileczo