Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ia32: add passing of graphmode params via syspage and platformctl #596

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

adamgreloch
Copy link
Member

@adamgreloch adamgreloch commented Sep 24, 2024

plo can now store graphics mode details in syspage (i.e. after setting the mode via VESA VBE) that are then accessible from userspace via platformctl

JIRA: RTOS-906

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: ia32

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

Copy link

github-actions bot commented Sep 24, 2024

Unit Test Results

7 725 tests  ±0   7 010 ✅ ±0   37m 23s ⏱️ -1s
  445 suites ±0     715 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 44fda1e. ± Comparison against base commit a10f91b.

♻️ This comment has been updated with latest results.

@adamgreloch adamgreloch marked this pull request as ready for review September 24, 2024 12:49
Copy link
Member

@agkaminski agkaminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nitpick, otherwise LGTM. I was wondering if we really need to pass this information from plo to user via kernel (as kernel does not seem to make any use of it), but I came to the conclusion that it is indeed justified.

include/arch/ia32/ia32.h Outdated Show resolved Hide resolved
plo can now store graphics mode details in syspage (i.e. after setting the mode via
VESA VBE) that are then accessible from userspace via platformctl

JIRA: RTOS-906
@adamgreloch adamgreloch merged commit d99dc74 into master Oct 4, 2024
34 checks passed
@adamgreloch adamgreloch deleted the adamgreloch/RTOS-906 branch October 4, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants