albertbog/host_port #76

albertbog · 2022-09-20T15:37:40Z

Description

Motivation and Context

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

Already covered by automatic testing.
New test added: (add PR link here).
Tested by hand on: (list targets here).

Checklist:

My change requires a change to the documentation.
I have updated the documentation accordingly.
I have added tests to cover my changes.
All new and existing linter checks and tests passed.
My changes generate no new compilation warnings for any of the targets.

Special treatment

This PR needs additional PRs to work (list the PRs, preferably in merge-order).
I will merge this PR by myself when appropriate.

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

shellcheck

contrib/ports/unix/example_app/iteropts.sh|20 col 34| Literal carriage return. Run script through tr -d '\r' . SC1017
contrib/ports/unix/example_app/iteropts.sh|21 col 5| Literal carriage return. Run script through tr -d '\r' . SC1017
contrib/ports/unix/example_app/iteropts.sh|22 col 20| Literal carriage return. Run script through tr -d '\r' . SC1017
contrib/ports/unix/example_app/iteropts.sh|23 col 11| Literal carriage return. Run script through tr -d '\r' . SC1017
contrib/ports/unix/example_app/iteropts.sh|24 col 1| Use 'popd ... || exit' or 'popd ... || return' in case popd fails. SC2164
contrib/ports/unix/example_app/iteropts.sh|24 col 5| Literal carriage return. Run script through tr -d '\r' . SC1017
contrib/apps/LwipMibCompiler/example/compile_udp_mib.sh|1 col 1| Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive. SC2148
contrib/apps/LwipMibCompiler/example/compile_udp_mib.sh|1 col 77| Literal carriage return. Run script through tr -d '\r' . SC1017

github-actions · 2022-09-20T15:38:06Z

contrib/ports/unix/example_app/iteropts.sh

@@ -0,0 +1,24 @@
+#!/bin/bash


🚫 [shellcheck] _{reported by reviewdog 🐶}
Literal carriage return. Run script through tr -d '\r' . SC1017

github-actions · 2022-09-20T15:38:07Z

contrib/ports/unix/example_app/iteropts.sh

@@ -0,0 +1,24 @@
+#!/bin/bash
+


🚫 [shellcheck] _{reported by reviewdog 🐶}
Literal carriage return. Run script through tr -d '\r' . SC1017

github-actions · 2022-09-20T15:38:07Z

contrib/ports/unix/example_app/iteropts.sh

@@ -0,0 +1,24 @@
+#!/bin/bash
+
+LOGFILE=iteropts.log


🚫 [shellcheck] _{reported by reviewdog 🐶}
Literal carriage return. Run script through tr -d '\r' . SC1017

github-actions · 2022-09-20T15:38:07Z

contrib/ports/unix/example_app/iteropts.sh

+#!/bin/bash
+
+LOGFILE=iteropts.log
+EXAPPDIR=../../../examples/example_app


🚫 [shellcheck] _{reported by reviewdog 🐶}
Literal carriage return. Run script through tr -d '\r' . SC1017

github-actions · 2022-09-20T15:38:07Z

contrib/ports/unix/example_app/iteropts.sh

+
+LOGFILE=iteropts.log
+EXAPPDIR=../../../examples/example_app
+


🚫 [shellcheck] _{reported by reviewdog 🐶}
Literal carriage return. Run script through tr -d '\r' . SC1017

github-actions · 2022-09-20T15:38:10Z

contrib/ports/unix/example_app/iteropts.sh

+    rm $EXAPPDIR/lwipopts_test.h
+    # cat the file to update its timestamp
+    cat $f > $EXAPPDIR/lwipopts_test.h
+    make TESTFLAGS=-DLWIP_OPTTEST_FILE -j 8 &> $BUILDLOG 2>&1 || echo file $f failed >> $LOGFILE


📝 [shellcheck] _{reported by reviewdog 🐶}
Double quote to prevent globbing and word splitting. SC2086

github-actions · 2022-09-20T15:38:10Z

contrib/ports/unix/example_app/iteropts.sh

+    rm $EXAPPDIR/lwipopts_test.h
+    # cat the file to update its timestamp
+    cat $f > $EXAPPDIR/lwipopts_test.h
+    make TESTFLAGS=-DLWIP_OPTTEST_FILE -j 8 &> $BUILDLOG 2>&1 || echo file $f failed >> $LOGFILE


📝 [shellcheck] _{reported by reviewdog 🐶}
Double quote to prevent globbing and word splitting. SC2086

github-actions · 2022-09-20T15:38:10Z

contrib/ports/unix/example_app/iteropts.sh

+    rm $EXAPPDIR/lwipopts_test.h
+    # cat the file to update its timestamp
+    cat $f > $EXAPPDIR/lwipopts_test.h
+    make TESTFLAGS=-DLWIP_OPTTEST_FILE -j 8 &> $BUILDLOG 2>&1 || echo file $f failed >> $LOGFILE


🚫 [shellcheck] _{reported by reviewdog 🐶}
Literal carriage return. Run script through tr -d '\r' . SC1017

github-actions · 2022-09-20T15:38:10Z

contrib/ports/unix/example_app/iteropts.sh

+    # cat the file to update its timestamp
+    cat $f > $EXAPPDIR/lwipopts_test.h
+    make TESTFLAGS=-DLWIP_OPTTEST_FILE -j 8 &> $BUILDLOG 2>&1 || echo file $f failed >> $LOGFILE
+    echo test $f done >> $LOGFILE


📝 [shellcheck] _{reported by reviewdog 🐶}
Double quote to prevent globbing and word splitting. SC2086

github-actions · 2022-09-20T15:38:11Z

contrib/ports/unix/example_app/iteropts.sh

+    # cat the file to update its timestamp
+    cat $f > $EXAPPDIR/lwipopts_test.h
+    make TESTFLAGS=-DLWIP_OPTTEST_FILE -j 8 &> $BUILDLOG 2>&1 || echo file $f failed >> $LOGFILE
+    echo test $f done >> $LOGFILE


⚠️ [shellcheck] _{reported by reviewdog 🐶}
Use semicolon or linefeed before 'done' (or quote to make it literal). SC1010

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

clang-format-pr

github-actions · 2022-09-20T15:38:12Z

contrib/Coverity/coverity.c

+struct pbuf;
+struct netif;
+
+void* mem_malloc(mem_size_t size)


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

void* mem_malloc(mem_size_t size)

void *mem_malloc(mem_size_t size)

github-actions · 2022-09-20T15:38:12Z

contrib/Coverity/coverity.c

+
+void* mem_malloc(mem_size_t size)
+{
+  __coverity_alloc__(size);


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

__coverity_alloc__(size);

__coverity_alloc__(size);

github-actions · 2022-09-20T15:38:13Z

contrib/Coverity/coverity.c

+{
+  __coverity_alloc__(size);
+}
+void mem_free(void* mem)


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

void mem_free(void* mem)

void mem_free(void *mem)

github-actions · 2022-09-20T15:38:13Z

contrib/Coverity/coverity.c

+}
+void mem_free(void* mem)
+{
+  __coverity_free__(mem);


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

__coverity_free__(mem);

__coverity_free__(mem);

github-actions · 2022-09-20T15:38:13Z

contrib/Coverity/coverity.c

+  __coverity_free__(mem);
+}
+
+void* memp_malloc(memp_t type)


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

void* memp_malloc(memp_t type)

void *memp_malloc(memp_t type)

github-actions · 2022-09-20T15:38:17Z

contrib/Coverity/coverity.c

+
+void abort(void)
+{
+  __coverity_panic__();


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

__coverity_panic__();

__coverity_panic__();

github-actions · 2022-09-20T15:38:17Z

contrib/Coverity/coverity.c

+  __coverity_panic__();
+}
+
+int check_path(char* path, size_t size)


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

int check_path(char* path, size_t size)

int check_path(char *path, size_t size)

github-actions · 2022-09-20T15:38:17Z

contrib/Coverity/coverity.c

+  if (size) {
+    __coverity_tainted_data_sanitize__(path);
+    return 1;
+  } else {
+    return 0;
+  }


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

if (size) {

__coverity_tainted_data_sanitize__(path);

return 1;

} else {

return 0;

}

if (size) {

__coverity_tainted_data_sanitize__(path);

return 1;

}

else {

return 0;

}

github-actions · 2022-09-20T15:38:18Z

contrib/addons/ipv6_static_routing/ip6_route_table.c

+
+#include "lwip/opt.h"
+
+#if LWIP_IPV6  /* don't build if not configured for use in lwipopts.h */


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

#if LWIP_IPV6 /* don't build if not configured for use in lwipopts.h */

#if LWIP_IPV6 /* don't build if not configured for use in lwipopts.h */

github-actions · 2022-09-20T15:38:18Z

contrib/addons/ipv6_static_routing/ip6_route_table.c

+err_t
+ip6_add_route_entry(const struct ip6_prefix *ip6_prefix, struct netif *netif, const ip6_addr_t *gateway, s8_t *idx)
+{
+  s8_t i = -1;
+  err_t retval = ERR_OK;
+
+  if (!ip6_prefix_valid(ip6_prefix->prefix_len) || (netif == NULL)) {
+    retval = ERR_ARG;
+    goto exit;
+  }
+
+  /* Check if an entry already exists with matching prefix; If so, replace it. */
+  for (i = 0; i < LWIP_IPV6_NUM_ROUTE_ENTRIES; i++) {
+    if ((ip6_prefix->prefix_len == static_route_table[i].prefix.prefix_len) &&
+        memcmp(&ip6_prefix->addr, &static_route_table[i].prefix.addr,
+               ip6_prefix->prefix_len / 8) == 0) {
+      /* Prefix matches; replace the netif with the one being added. */
+      goto insert;
+    }
+  }
+
+  /* Check if the table is full */
+  if (static_route_table[LWIP_IPV6_NUM_ROUTE_ENTRIES - 1].netif != NULL) {
+    retval = ERR_MEM;
+    goto exit;
+  }
+
+  /* Shift all entries down the table until slot is found */
+  for (i = LWIP_IPV6_NUM_ROUTE_ENTRIES - 1;
+       i > 0 && (ip6_prefix->prefix_len > static_route_table[i - 1].prefix.prefix_len); i--) {
+    SMEMCPY(&static_route_table[i], &static_route_table[i - 1], sizeof(struct ip6_route_entry));
+  }


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

err_t

ip6_add_route_entry(const struct ip6_prefix *ip6_prefix, struct netif *netif, const ip6_addr_t *gateway, s8_t *idx)

{

s8_t i = -1;

err_t retval = ERR_OK;

if (!ip6_prefix_valid(ip6_prefix->prefix_len) || (netif == NULL)) {

retval = ERR_ARG;

goto exit;

}

/* Check if an entry already exists with matching prefix; If so, replace it. */

for (i = 0; i < LWIP_IPV6_NUM_ROUTE_ENTRIES; i++) {

if ((ip6_prefix->prefix_len == static_route_table[i].prefix.prefix_len) &&

memcmp(&ip6_prefix->addr, &static_route_table[i].prefix.addr,

ip6_prefix->prefix_len / 8) == 0) {

/* Prefix matches; replace the netif with the one being added. */

goto insert;

}

}

/* Check if the table is full */

if (static_route_table[LWIP_IPV6_NUM_ROUTE_ENTRIES - 1].netif != NULL) {

retval = ERR_MEM;

goto exit;

}

/* Shift all entries down the table until slot is found */

for (i = LWIP_IPV6_NUM_ROUTE_ENTRIES - 1;

i > 0 && (ip6_prefix->prefix_len > static_route_table[i - 1].prefix.prefix_len); i--) {

SMEMCPY(&static_route_table[i], &static_route_table[i - 1], sizeof(struct ip6_route_entry));

}

err_t ip6_add_route_entry(const struct ip6_prefix *ip6_prefix, struct netif *netif, const ip6_addr_t *gateway, s8_t *idx)

{

s8_t i = -1;

err_t retval = ERR_OK;

if (!ip6_prefix_valid(ip6_prefix->prefix_len) || (netif == NULL)) {

retval = ERR_ARG;

goto exit;

}

/* Check if an entry already exists with matching prefix; If so, replace it. */

for (i = 0; i < LWIP_IPV6_NUM_ROUTE_ENTRIES; i++) {

if ((ip6_prefix->prefix_len == static_route_table[i].prefix.prefix_len) &&

memcmp(&ip6_prefix->addr, &static_route_table[i].prefix.addr,

ip6_prefix->prefix_len / 8) == 0) {

/* Prefix matches; replace the netif with the one being added. */

goto insert;

}

}

/* Check if the table is full */

if (static_route_table[LWIP_IPV6_NUM_ROUTE_ENTRIES - 1].netif != NULL) {

retval = ERR_MEM;

goto exit;

}

/* Shift all entries down the table until slot is found */

for (i = LWIP_IPV6_NUM_ROUTE_ENTRIES - 1;

i > 0 && (ip6_prefix->prefix_len > static_route_table[i - 1].prefix.prefix_len); i--) {

SMEMCPY(&static_route_table[i], &static_route_table[i - 1], sizeof(struct ip6_route_entry));

}

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

codespell

github-actions · 2022-09-20T15:38:20Z

include/default-opts/unix/lwipopts.h

+#define MEMP_NUM_UDP_PCB                4
+
+/**
+ * MEMP_NUM_TCP_PCB: the number of simulatenously active TCP connections.


[codespell] _{reported by reviewdog 🐶}
simulatenously ==> simultaneously

github-actions · 2022-09-20T15:38:21Z

include/default-opts/unix/lwipopts.h

+
+/**
+ * PBUF_POOL_BUFSIZE: the size of each pbuf in the pbuf pool. The default is
+ * designed to accomodate single full size TCP frame in one pbuf, including


[codespell] _{reported by reviewdog 🐶}
accomodate ==> accommodate

github-actions · 2022-09-20T15:38:21Z

contrib/Filelists.cmake

@@ -0,0 +1,56 @@
+# This file is indended to be included in end-user CMakeLists.txt


[codespell] _{reported by reviewdog 🐶}
indended ==> intended, indented

github-actions · 2022-09-20T15:38:21Z

contrib/apps/shell/shell.c

+static char help_msg2[] = "udpn [local UDP port] [IP address] [remote port]: opens a UDP \"connection\" without checksums."NEWLINE"\
+udpb [local port] [remote port]: opens a UDP broadcast \"connection\"."NEWLINE"\
+usnd [connection #] [message]: sends a message on a UDP connection."NEWLINE"\
+recv [connection #]: recieves data on a TCP or UDP connection."NEWLINE"\


[codespell] _{reported by reviewdog 🐶}
recieves ==> receives

github-actions · 2022-09-20T15:38:21Z

contrib/apps/shell/shell.c

+udpb [local port] [remote port]: opens a UDP broadcast \"connection\"."NEWLINE"\
+usnd [connection #] [message]: sends a message on a UDP connection."NEWLINE"\
+recv [connection #]: recieves data on a TCP or UDP connection."NEWLINE"\
+clos [connection #]: closes a TCP or UDP connection."NEWLINE"\


[codespell] _{reported by reviewdog 🐶}
clos ==> close

github-actions · 2022-09-20T15:38:24Z

contrib/apps/LwipMibCompiler/Mibs/IP-MIB

+    REVISION      "200602020000Z"
+    DESCRIPTION
+           "The IP version neutral revision with added IPv6 objects for
+            ND, default routers, and router advertisements.  As well as


[codespell] _{reported by reviewdog 🐶}
ND ==> AND, 2ND

github-actions · 2022-09-20T15:38:24Z

contrib/apps/LwipMibCompiler/Mibs/RFC1213-MIB

+            object refers to a document defining objects
+            specific to ethernet.  If this information is not
+            present, its value should be set to the OBJECT
+            IDENTIFIER { 0 0 }, which is a syntatically valid


[codespell] _{reported by reviewdog 🐶}
syntatically ==> syntactically

github-actions · 2022-09-20T15:38:24Z

contrib/apps/LwipMibCompiler/Mibs/RFC1213-MIB

+            Setting this object to a null string (one of zero
+            length) has the effect of invaliding the
+            corresponding entry in the atTable object.  That
+            is, it effectively dissasociates the interface


[codespell] _{reported by reviewdog 🐶}
dissasociates ==> disassociates

github-actions · 2022-09-20T15:38:24Z

contrib/apps/LwipMibCompiler/Mibs/RFC1213-MIB

+            Setting this object to the value invalid(2) has
+            the effect of invalidating the corresponding entry
+            in the ipRouteTable object.  That is, it
+            effectively dissasociates the destination


[codespell] _{reported by reviewdog 🐶}
dissasociates ==> disassociates

github-actions · 2022-09-20T15:38:25Z

contrib/apps/LwipMibCompiler/Mibs/RFC1213-MIB

+            specified in the route's ipRouteProto value.  If
+            this information is not present, its value should
+            be set to the OBJECT IDENTIFIER { 0 0 }, which is
+            a syntatically valid object identifier, and any


[codespell] _{reported by reviewdog 🐶}
syntatically ==> syntactically

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

clang-format-pr

github-actions · 2022-09-28T11:23:08Z

contrib/addons/ipv6_static_routing/ip6_route_table.c

+  /* Insert into the slot selected */
+  SMEMCPY(&static_route_table[i].prefix, ip6_prefix, sizeof(struct ip6_prefix));
+  static_route_table[i].netif = netif;
+
+  /* Add gateway to route table */
+  static_route_table[i].gateway = gateway;
+
+  if (idx != NULL) {
+    *idx = i;
+  }


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

/* Insert into the slot selected */

SMEMCPY(&static_route_table[i].prefix, ip6_prefix, sizeof(struct ip6_prefix));

static_route_table[i].netif = netif;

/* Add gateway to route table */

static_route_table[i].gateway = gateway;

if (idx != NULL) {

*idx = i;

}

/* Insert into the slot selected */

SMEMCPY(&static_route_table[i].prefix, ip6_prefix, sizeof(struct ip6_prefix));

static_route_table[i].netif = netif;

/* Add gateway to route table */

static_route_table[i].gateway = gateway;

if (idx != NULL) {

*idx = i;

}

github-actions · 2022-09-28T11:23:09Z

contrib/addons/ipv6_static_routing/ip6_route_table.c

+  }
+
+exit:
+  return retval;


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

return retval;

return retval;

github-actions · 2022-09-28T11:23:09Z

contrib/addons/ipv6_static_routing/ip6_route_table.c

+void
+ip6_remove_route_entry(const struct ip6_prefix *ip6_prefix)
+{
+  int i, pos = -1;
+
+  for (i = 0; i < LWIP_IPV6_NUM_ROUTE_ENTRIES; i++) {
+    /* compare prefix to find position to delete */
+    if (ip6_prefix->prefix_len == static_route_table[i].prefix.prefix_len &&
+        memcmp(&ip6_prefix->addr, &static_route_table[i].prefix.addr,
+               ip6_prefix->prefix_len / 8) == 0) {
+      pos = i;
+      break;
+    }
+  }
+
+  if (pos >= 0) {
+    /* Shift everything beyond pos one slot up */
+    for (i = pos; i < LWIP_IPV6_NUM_ROUTE_ENTRIES - 1; i++) {
+      SMEMCPY(&static_route_table[i], &static_route_table[i+1], sizeof(struct ip6_route_entry));
+      if (static_route_table[i].netif == NULL) {
+        break;
+      }
+    }
+    /* Zero the remaining entries */
+    for (; i < LWIP_IPV6_NUM_ROUTE_ENTRIES; i++) {
+      ip6_addr_set_zero((&static_route_table[i].prefix.addr));
+      static_route_table[i].netif = NULL;
+    }
+  }


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

void

ip6_remove_route_entry(const struct ip6_prefix *ip6_prefix)

{

int i, pos = -1;

for (i = 0; i < LWIP_IPV6_NUM_ROUTE_ENTRIES; i++) {

/* compare prefix to find position to delete */

if (ip6_prefix->prefix_len == static_route_table[i].prefix.prefix_len &&

memcmp(&ip6_prefix->addr, &static_route_table[i].prefix.addr,

ip6_prefix->prefix_len / 8) == 0) {

pos = i;

break;

}

}

if (pos >= 0) {

/* Shift everything beyond pos one slot up */

for (i = pos; i < LWIP_IPV6_NUM_ROUTE_ENTRIES - 1; i++) {

SMEMCPY(&static_route_table[i], &static_route_table[i+1], sizeof(struct ip6_route_entry));

if (static_route_table[i].netif == NULL) {

break;

}

}

/* Zero the remaining entries */

for (; i < LWIP_IPV6_NUM_ROUTE_ENTRIES; i++) {

ip6_addr_set_zero((&static_route_table[i].prefix.addr));

static_route_table[i].netif = NULL;

}

}

void ip6_remove_route_entry(const struct ip6_prefix *ip6_prefix)

{

int i, pos = -1;

for (i = 0; i < LWIP_IPV6_NUM_ROUTE_ENTRIES; i++) {

/* compare prefix to find position to delete */

if (ip6_prefix->prefix_len == static_route_table[i].prefix.prefix_len &&

memcmp(&ip6_prefix->addr, &static_route_table[i].prefix.addr,

ip6_prefix->prefix_len / 8) == 0) {

pos = i;

break;

}

}

if (pos >= 0) {

/* Shift everything beyond pos one slot up */

for (i = pos; i < LWIP_IPV6_NUM_ROUTE_ENTRIES - 1; i++) {

SMEMCPY(&static_route_table[i], &static_route_table[i + 1], sizeof(struct ip6_route_entry));

if (static_route_table[i].netif == NULL) {

break;

}

}

/* Zero the remaining entries */

for (; i < LWIP_IPV6_NUM_ROUTE_ENTRIES; i++) {

ip6_addr_set_zero((&static_route_table[i].prefix.addr));

static_route_table[i].netif = NULL;

}

}

github-actions · 2022-09-28T11:23:10Z

contrib/addons/ipv6_static_routing/ip6_route_table.c

+s8_t
+ip6_find_route_entry(const ip6_addr_t *ip6_dest_addr)
+{
+  s8_t i, idx = -1;
+
+  /* Search prefix in the sorted(decreasing order of prefix length) list */
+  for(i = 0; i < LWIP_IPV6_NUM_ROUTE_ENTRIES; i++) {
+    if (memcmp(ip6_dest_addr, &static_route_table[i].prefix.addr,
+        static_route_table[i].prefix.prefix_len / 8) == 0) {
+      idx = i;
+      break;
+    }
+  }
+
+  return idx;


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

s8_t

ip6_find_route_entry(const ip6_addr_t *ip6_dest_addr)

{

s8_t i, idx = -1;

/* Search prefix in the sorted(decreasing order of prefix length) list */

for(i = 0; i < LWIP_IPV6_NUM_ROUTE_ENTRIES; i++) {

if (memcmp(ip6_dest_addr, &static_route_table[i].prefix.addr,

static_route_table[i].prefix.prefix_len / 8) == 0) {

idx = i;

break;

}

}

return idx;

s8_t ip6_find_route_entry(const ip6_addr_t *ip6_dest_addr)

{

s8_t i, idx = -1;

/* Search prefix in the sorted(decreasing order of prefix length) list */

for (i = 0; i < LWIP_IPV6_NUM_ROUTE_ENTRIES; i++) {

if (memcmp(ip6_dest_addr, &static_route_table[i].prefix.addr,

static_route_table[i].prefix.prefix_len / 8) == 0) {

idx = i;

break;

}

}

return idx;

github-actions · 2022-09-28T11:23:10Z

contrib/addons/ipv6_static_routing/ip6_route_table.c

+  int i;
+
+  LWIP_UNUSED_ARG(src);
+
+  /* Perform table lookup */
+  i = ip6_find_route_entry(dest);
+
+  if (i >= 0) {
+    return static_route_table[i].netif;
+  } else {
+    return NULL;
+  }


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

int i;

LWIP_UNUSED_ARG(src);

/* Perform table lookup */

i = ip6_find_route_entry(dest);

if (i >= 0) {

return static_route_table[i].netif;

} else {

return NULL;

}

int i;

LWIP_UNUSED_ARG(src);

/* Perform table lookup */

i = ip6_find_route_entry(dest);

if (i >= 0) {

return static_route_table[i].netif;

}

else {

return NULL;

}

github-actions · 2022-09-28T11:23:16Z

contrib/addons/netconn/external_resolve/dnssd.c

+    /* We got a response */
+    if (msg.err == ERR_OK) {
+      struct sockaddr_in* addr_in = (struct sockaddr_in *)&msg.addr;
+      if (addr_in->sin_family == AF_INET) {
+        inet_addr_to_ip4addr(ip_2_ip4(addr), &addr_in->sin_addr);
+      } else {
+        /* @todo add IPv6 support */
+        msg.err = ERR_VAL;
+      }
+    }
+  }
+  sys_sem_free(&msg.sem);


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

/* We got a response */

if (msg.err == ERR_OK) {

struct sockaddr_in* addr_in = (struct sockaddr_in *)&msg.addr;

if (addr_in->sin_family == AF_INET) {

inet_addr_to_ip4addr(ip_2_ip4(addr), &addr_in->sin_addr);

} else {

/* @todo add IPv6 support */

msg.err = ERR_VAL;

}

}

}

sys_sem_free(&msg.sem);

/* We got a response */

if (msg.err == ERR_OK) {

struct sockaddr_in *addr_in = (struct sockaddr_in *)&msg.addr;

if (addr_in->sin_family == AF_INET) {

inet_addr_to_ip4addr(ip_2_ip4(addr), &addr_in->sin_addr);

}

else {

/* @todo add IPv6 support */

msg.err = ERR_VAL;

}

}

}

sys_sem_free(&msg.sem);

github-actions · 2022-09-28T11:23:16Z

contrib/addons/netconn/external_resolve/dnssd.c

+*err = msg.err;
+return 1;


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

*err = msg.err;

return 1;

*err = msg.err;

return 1;

github-actions · 2022-09-28T11:23:16Z

contrib/addons/netconn/external_resolve/dnssd.c

+                   DNSServiceErrorType error_code, char const* hostname,
+                   const struct sockaddr* address, u32_t ttl, void* context)


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

DNSServiceErrorType error_code, char const* hostname,

const struct sockaddr* address, u32_t ttl, void* context)

DNSServiceErrorType error_code, char const *hostname,

const struct sockaddr *address, u32_t ttl, void *context)

github-actions · 2022-09-28T11:23:16Z

contrib/addons/netconn/external_resolve/dnssd.c

+  struct addr_clbk_msg* msg = (struct addr_clbk_msg*)context;
+  struct sockaddr_in*  addr_in = (struct sockaddr_in *)address;


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

struct addr_clbk_msg* msg = (struct addr_clbk_msg*)context;

struct sockaddr_in* addr_in = (struct sockaddr_in *)address;

struct addr_clbk_msg *msg = (struct addr_clbk_msg *)context;

struct sockaddr_in *addr_in = (struct sockaddr_in *)address;

github-actions · 2022-09-28T11:23:17Z

contrib/addons/netconn/external_resolve/dnssd.c

+  LWIP_UNUSED_ARG(ref);
+  LWIP_UNUSED_ARG(flags);
+  LWIP_UNUSED_ARG(interface_index);
+  LWIP_UNUSED_ARG(hostname);
+  LWIP_UNUSED_ARG(ttl);
+  LWIP_UNUSED_ARG(context);


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

LWIP_UNUSED_ARG(ref);

LWIP_UNUSED_ARG(flags);

LWIP_UNUSED_ARG(interface_index);

LWIP_UNUSED_ARG(hostname);

LWIP_UNUSED_ARG(ttl);

LWIP_UNUSED_ARG(context);

LWIP_UNUSED_ARG(ref);

LWIP_UNUSED_ARG(flags);

LWIP_UNUSED_ARG(interface_index);

LWIP_UNUSED_ARG(hostname);

LWIP_UNUSED_ARG(ttl);

LWIP_UNUSED_ARG(context);

github-actions · 2022-09-28T11:23:27Z

contrib/ports/unix/example_app/iteropts.sh

+LOGFILE=iteropts.log
+EXAPPDIR=../../../examples/example_app
+
+pushd `dirname "$0"`


[shellcheck (suggestion)] _{reported by reviewdog 🐶}

Suggested change

pushd `dirname "$0"`

pushd $(dirname "$0") || exit

github-actions · 2022-09-28T11:23:27Z

contrib/ports/unix/example_app/iteropts.sh

+    echo testing $f
+    echo testing $f >> $LOGFILE


[shellcheck (suggestion)] _{reported by reviewdog 🐶}

Suggested change

echo testing $f

echo testing $f >> $LOGFILE

echo testing "$f"

echo testing "$f" >> $LOGFILE

github-actions · 2022-09-28T11:23:28Z

contrib/ports/unix/example_app/iteropts.sh

+    cat $f > $EXAPPDIR/lwipopts_test.h
+    make TESTFLAGS=-DLWIP_OPTTEST_FILE -j 8 &> $BUILDLOG 2>&1 || echo file $f failed >> $LOGFILE
+    echo test $f done >> $LOGFILE


[shellcheck (suggestion)] _{reported by reviewdog 🐶}

Suggested change

cat $f > $EXAPPDIR/lwipopts_test.h

make TESTFLAGS=-DLWIP_OPTTEST_FILE -j 8 &> $BUILDLOG 2>&1 || echo file $f failed >> $LOGFILE

echo test $f done >> $LOGFILE

cat "$f" > $EXAPPDIR/lwipopts_test.h

make TESTFLAGS=-DLWIP_OPTTEST_FILE -j 8 &> "$BUILDLOG" 2>&1 || echo file "$f" failed >> $LOGFILE

echo test "$f" done >> $LOGFILE

github-actions · 2022-09-28T11:23:28Z

contrib/ports/unix/example_app/iteropts.sh

+done
+echo done, cleaning
+make clean
+popd


[shellcheck (suggestion)] _{reported by reviewdog 🐶}

Suggested change

popd

popd || exit

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

codespell

github-actions · 2022-09-28T11:23:29Z

contrib/ports/unix/Filelists.cmake

@@ -0,0 +1,40 @@
+# This file is indended to be included in end-user CMakeLists.txt


[codespell] _{reported by reviewdog 🐶}
indended ==> intended, indented

github-actions · 2022-09-28T11:23:30Z

contrib/ports/unix/README

@@ -0,0 +1,25 @@
+This port contains infrastructure and examples for running lwIP on Unix-like
+operating systems (Linux, OpenBSD, cygwin). Much of this is targetted towards


[codespell] _{reported by reviewdog 🐶}
targetted ==> targeted

github-actions · 2022-09-28T11:23:30Z

contrib/ports/unix/lib/lwipopts.h

+#define MEMP_NUM_UDP_PCB                4
+
+/**
+ * MEMP_NUM_TCP_PCB: the number of simulatenously active TCP connections.


[codespell] _{reported by reviewdog 🐶}
simulatenously ==> simultaneously

github-actions · 2022-09-28T11:23:30Z

contrib/ports/unix/lib/lwipopts.h

+
+/**
+ * PBUF_POOL_BUFSIZE: the size of each pbuf in the pbuf pool. The default is
+ * designed to accomodate single full size TCP frame in one pbuf, including


[codespell] _{reported by reviewdog 🐶}
accomodate ==> accommodate

contrib/ports/unix/port/sys_arch.c

github-actions · 2022-09-28T11:23:34Z

contrib/apps/LwipMibCompiler/LwipMibCompiler/Program.cs

+			}
+			else
+			{
+				// not accessible or unsupported accress type


[codespell] _{reported by reviewdog 🐶}
accress ==> access

github-actions · 2022-09-28T11:23:34Z

contrib/apps/LwipMibCompiler/LwipMibCompiler/Program.cs

+				{
+					result.AugmentedTableRow = rot.Augments;
+
+					// the indeces from another table shall be used because this table is only an extension of it


[codespell] _{reported by reviewdog 🐶}
indeces ==> indices

contrib/apps/LwipMibCompiler/LwipMibCompiler/Properties/AssemblyInfo.cs

github-actions · 2022-09-28T11:30:40Z

contrib/apps/LwipMibCompiler/example/compile_udp_mib.sh

@@ -0,0 +1 @@
+../LwipMibCompiler/bin/Debug/LwipMibCompiler.exe ../Mibs/UDP-MIB ./ ../Mibs/


🚫 [shellcheck] _{reported by reviewdog 🐶}
Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive. SC2148

github-actions · 2022-09-28T11:30:41Z

contrib/apps/LwipMibCompiler/example/compile_udp_mib.sh

@@ -0,0 +1 @@
+../LwipMibCompiler/bin/Debug/LwipMibCompiler.exe ../Mibs/UDP-MIB ./ ../Mibs/


🚫 [shellcheck] _{reported by reviewdog 🐶}
Literal carriage return. Run script through tr -d '\r' . SC1017

github-actions · 2022-09-28T11:30:41Z

contrib/ports/unix/example_app/iteropts.sh

+    # cat the file to update its timestamp
+    cat $f > $EXAPPDIR/lwipopts_test.h
+    make TESTFLAGS=-DLWIP_OPTTEST_FILE -j 8 &> $BUILDLOG 2>&1 || echo file $f failed >> $LOGFILE
+    echo test $f done >> $LOGFILE


🚫 [shellcheck] _{reported by reviewdog 🐶}
Literal carriage return. Run script through tr -d '\r' . SC1017

github-actions · 2022-09-28T11:30:41Z

contrib/ports/unix/example_app/iteropts.sh

+    cat $f > $EXAPPDIR/lwipopts_test.h
+    make TESTFLAGS=-DLWIP_OPTTEST_FILE -j 8 &> $BUILDLOG 2>&1 || echo file $f failed >> $LOGFILE
+    echo test $f done >> $LOGFILE
+done


🚫 [shellcheck] _{reported by reviewdog 🐶}
Literal carriage return. Run script through tr -d '\r' . SC1017

github-actions · 2022-09-28T11:30:41Z

contrib/ports/unix/example_app/iteropts.sh

+    make TESTFLAGS=-DLWIP_OPTTEST_FILE -j 8 &> $BUILDLOG 2>&1 || echo file $f failed >> $LOGFILE
+    echo test $f done >> $LOGFILE
+done
+echo done, cleaning


🚫 [shellcheck] _{reported by reviewdog 🐶}
Literal carriage return. Run script through tr -d '\r' . SC1017

github-actions · 2022-09-28T11:30:41Z

contrib/ports/unix/example_app/iteropts.sh

+    echo test $f done >> $LOGFILE
+done
+echo done, cleaning
+make clean


🚫 [shellcheck] _{reported by reviewdog 🐶}
Literal carriage return. Run script through tr -d '\r' . SC1017

github-actions · 2022-09-28T11:30:41Z

contrib/ports/unix/example_app/iteropts.sh

+done
+echo done, cleaning
+make clean
+popd


⚠️ [shellcheck] _{reported by reviewdog 🐶}
Use 'popd ... || exit' or 'popd ... || return' in case popd fails. SC2164

github-actions · 2022-09-28T11:30:41Z

contrib/ports/unix/example_app/iteropts.sh

+done
+echo done, cleaning
+make clean
+popd


🚫 [shellcheck] _{reported by reviewdog 🐶}
Literal carriage return. Run script through tr -d '\r' . SC1017

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

codespell

contrib/apps/udpecho_raw/udpecho_raw.c|35| Linz ==> Lines
contrib/examples/httpd/post_example/post_example.c|136| conenction ==> connection
contrib/examples/example_app/lwipopts.h|133| simulatenously ==> simultaneously

contrib/apps/LwipMibCompiler/LwipMibCompiler/Properties/AssemblyInfo.cs

github-actions · 2022-09-28T11:30:45Z

contrib/apps/LwipMibCompiler/LwipSnmpCodeGeneration/SnmpTreeNode.cs

+
+			base.Analyze();
+
+			// check if we can merge this node to a scalar array node (all childs need to be scalars)


[codespell] _{reported by reviewdog 🐶}
childs ==> children, child's

github-actions · 2022-09-28T11:30:49Z

contrib/apps/LwipMibCompiler/SharpSnmpLib/Mib/Elements/Types/Sequence.cs

+namespace Lextm.SharpSnmpLib.Mib.Elements.Types
+{
+    /// <summary>
+    /// The SEQUENCE type represents a set of specified types. This is roughtly analogous to a <code>struct</code> in C.


[codespell] _{reported by reviewdog 🐶}
roughtly ==> roughly

contrib/apps/udpecho_raw/udpecho_raw.h

contrib/apps/udpecho_raw/udpecho_raw.c

nalajcie

Please add contrib as a submodule without copying all of the files (if You search git history - it already was once in repo). If there are no changes in the contrib - use upstream repo (preferable) or create a fork in our organization (the same as for lwip).

xvuko · 2022-09-29T11:43:42Z

Makefile


-include ../phoenix-rtos-build/Makefile.common
+LWIP_LOCAL_DIR := $(dir $(lastword $(MAKEFILE_LIST)))


Suggested change

LWIP_LOCAL_DIR := $(dir $(lastword $(MAKEFILE_LIST)))

# calling my-dir works only when Makefile.common is already included before including this file

# as this is not a case here we need to this manually

LWIP_LOCAL_DIR := $(dir $(lastword $(MAKEFILE_LIST)))

xvuko · 2022-09-29T11:47:06Z

Makefile

+LWIPPORT_DIR ?= include/
+
+# port specific definitions
+include contrib/Makefile


To allow using contrib as submodule contrib makefile needs to be placed elsewhere.

Maybe: Makefile.contrib

xvuko · 2022-09-29T12:21:23Z

Makefile

+LWIPOPTS_DIR ?= include/default-opts
+LWIPPORT_DIR ?= include/


overwriten in contrib/Makefile

xvuko · 2022-09-29T13:44:50Z

drivers/netif-driver.c

-
-#include <sys/threads.h>
+#include <arch/sys_arch.h>
+#include <pthread.h>


pthread should not be needed

xvuko · 2022-09-29T13:49:51Z

drivers/pppos.c

 	// wait for result with optional response text
 	int off = 0;
 	while (off < max_len) {
+		usleep(timeout_ms*1000);


Why is this needed?

xvuko · 2022-09-29T14:03:34Z

drivers/netif-driver.c

@@ -123,7 +123,7 @@ int create_netif(char *conf)
 		*arg++ = 0;

 	is_ppp = (arg != NULL) && (strncmp(conf, "ppp", 3) == 0);
-	//printf("netif: driver '%s' args '%s' is_ppp=%d\n", conf, arg, is_ppp);
+	printf("netif: driver '%s' args '%s' is_ppp=%d\n", conf, arg, is_ppp);


Maybe log_* function?

xvuko · 2022-09-29T14:05:24Z

drivers/netif-driver.c

@@ -140,6 +140,7 @@ int create_netif(char *conf)
 		return -ENOMEM;

 	ni = &storage->netif;
+	netif_default = ni;


xvuko · 2022-09-29T14:20:34Z

drivers/pppos.c

@@ -699,7 +694,7 @@ static int pppos_netifInit(struct netif *netif, char *cfg)
 	memset(state, 0, sizeof(pppos_priv_t));
 	state->netif = netif;
 	state->serialdev_fn = cfg;
-	state->serialat_fn = "/dev/ttyacm1";
+	state->serialat_fn = "/dev/ttyACM0";


Please do not change hardcoded paths to match your machine.

Suggested change

state->serialat_fn = "/dev/ttyACM0";

/* TODO: return error if device path is not found in cfg */

state->serialat_fn = "/dev/ttyacm1";

github-actions · 2022-09-29T14:51:52Z

contrib/apps/udpecho_raw/udpecho_raw.c

+ *
+ * Credits go to Adam Dunkels (and the current maintainers) of this software.
+ *
+ * Stephan Linz rewrote this file to get a basic echo example.


[codespell] _{reported by reviewdog 🐶}
Linz ==> Lines

github-actions · 2022-09-29T14:51:52Z

contrib/examples/httpd/post_example/post_example.c

+      }
+    }
+    /* not returning ERR_OK aborts the connection, so return ERR_OK unless the
+       conenction is unknown */


[codespell] _{reported by reviewdog 🐶}
conenction ==> connection

github-actions · 2022-09-29T14:51:52Z

contrib/examples/example_app/lwipopts.h

+/* MEMP_NUM_UDP_PCB: the number of UDP protocol control blocks. One
+   per active UDP "connection". */
+#define MEMP_NUM_UDP_PCB        4
+/* MEMP_NUM_TCP_PCB: the number of simulatenously active TCP


[codespell] _{reported by reviewdog 🐶}
simulatenously ==> simultaneously

JIRA: ISM-117 Signed-off-by: Albert Bogdanovic <[email protected]>

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

clang-format-pr

github-actions · 2022-09-30T14:35:27Z

drivers/netif-driver.c

 	}
 }
+


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

github-actions · 2022-09-30T14:35:28Z

drivers/pppos.c

-	handle_t lock, cond;
-
+	sys_sem_t sem;
+	


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

github-actions · 2022-09-30T14:35:28Z

drivers/pppos.c

 	uint32_t main_loop_stack[4096];
 } pppos_priv_t;

+static pppos_priv_t* state;


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

static pppos_priv_t* state;

static pppos_priv_t *state;

github-actions · 2022-09-30T14:35:28Z

drivers/pppos.c

@@ -224,7 +231,7 @@ static int at_send_cmd_res(int fd, const char* cmd, int timeout_ms, char *rx_buf
 	end = strstr(cmd, "\r\n");
 	/* remove newlines for better result printing */
 	log_at("AT Tx: [%*s]", (end != NULL) ? end - cmd : strlen(cmd), cmd);
-
+	


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

github-actions · 2022-09-30T14:35:28Z

drivers/pppos.c

 		while (!state->want_connected) {
-			condWait(state->cond, state->lock, 0);
+			sys_arch_sem_wait(&(state->sem),0);


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

sys_arch_sem_wait(&(state->sem),0);

sys_arch_sem_wait(&(state->sem), 0);

github-actions · 2022-09-30T14:35:32Z

include/default-opts/unix/lwipopts.h

+ * MEMP_NUM_TCP_SEG: the number of simultaneously queued TCP segments.
+ * (requires the LWIP_TCP option)
+ */
+#define MEMP_NUM_TCP_SEG                16


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

#define MEMP_NUM_TCP_SEG 16

#define MEMP_NUM_TCP_SEG 16

github-actions · 2022-09-30T14:35:32Z

include/default-opts/unix/lwipopts.h

+ * MEMP_NUM_REASSDATA: the number of simultaneously IP packets queued for
+ * reassembly (whole packets, not fragments!)
+ */
+#define MEMP_NUM_REASSDATA              1


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

#define MEMP_NUM_REASSDATA 1

#define MEMP_NUM_REASSDATA 1

github-actions · 2022-09-30T14:35:33Z

include/default-opts/unix/lwipopts.h

+ * their destination address) to finish.
+ * (requires the ARP_QUEUEING option)
+ */
+#define MEMP_NUM_ARP_QUEUE              2


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

#define MEMP_NUM_ARP_QUEUE 2

#define MEMP_NUM_ARP_QUEUE 2

github-actions · 2022-09-30T14:35:33Z

include/default-opts/unix/lwipopts.h

+ * MEMP_NUM_SYS_TIMEOUT: the number of simulateously active timeouts.
+ * (requires NO_SYS==0)
+ */
+#define MEMP_NUM_SYS_TIMEOUT            8


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

#define MEMP_NUM_SYS_TIMEOUT 8

#define MEMP_NUM_SYS_TIMEOUT 8

github-actions · 2022-09-30T14:35:33Z

include/default-opts/unix/lwipopts.h

+ * MEMP_NUM_NETBUF: the number of struct netbufs.
+ * (only needed if you use the sequential API, like api_lib.c)
+ */
+#define MEMP_NUM_NETBUF                 2


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

#define MEMP_NUM_NETBUF 2

#define MEMP_NUM_NETBUF 2

albertbog requested review from anglov and xvuko September 20, 2022 15:37

github-actions bot reviewed Sep 20, 2022

View reviewed changes

github-actions bot reviewed Sep 28, 2022

View reviewed changes

albertbog force-pushed the albertbog/host_port branch from d42b2da to 159e525 Compare September 28, 2022 11:30

github-actions bot reviewed Sep 28, 2022

View reviewed changes

nalajcie requested changes Sep 28, 2022

View reviewed changes

xvuko reviewed Sep 29, 2022

View reviewed changes

albertbog force-pushed the albertbog/host_port branch from 159e525 to af553d2 Compare September 29, 2022 14:51

github-actions bot reviewed Sep 29, 2022

View reviewed changes

Albert Bogdanovic added 2 commits September 30, 2022 16:31

LwIP: add contrib 2.1.0

bd2125e

JIRA: ISM-117 Signed-off-by: Albert Bogdanovic <[email protected]>

add pc host port support

cc433fa

albertbog force-pushed the albertbog/host_port branch from af553d2 to cc433fa Compare September 30, 2022 14:34

github-actions bot reviewed Sep 30, 2022

View reviewed changes

albertbog marked this pull request as ready for review September 30, 2022 14:37

	void* mem_malloc(mem_size_t size)
	void *mem_malloc(mem_size_t size)

	void* memp_malloc(memp_t type)
	void *memp_malloc(memp_t type)

	int check_path(char* path, size_t size)
	int check_path(char *path, size_t size)


		#include "lwip/opt.h"

		#if LWIP_IPV6 /* don't build if not configured for use in lwipopts.h */

		@@ -0,0 +1,56 @@
		# This file is indended to be included in end-user CMakeLists.txt

		DNSServiceErrorType error_code, char const* hostname,
		const struct sockaddr* address, u32_t ttl, void* context)

		struct addr_clbk_msg* msg = (struct addr_clbk_msg*)context;
		struct sockaddr_in* addr_in = (struct sockaddr_in *)address;

		@@ -0,0 +1,40 @@
		# This file is indended to be included in end-user CMakeLists.txt

		@@ -0,0 +1,25 @@
		This port contains infrastructure and examples for running lwIP on Unix-like
		operating systems (Linux, OpenBSD, cygwin). Much of this is targetted towards

		@@ -0,0 +1 @@
		../LwipMibCompiler/bin/Debug/LwipMibCompiler.exe ../Mibs/UDP-MIB ./ ../Mibs/

		@@ -0,0 +1,24 @@
		#!/bin/bash

		LOGFILE=iteropts.log


		LOGFILE=iteropts.log
		EXAPPDIR=../../../examples/example_app


		base.Analyze();

		// check if we can merge this node to a scalar array node (all childs need to be scalars)


		include ../phoenix-rtos-build/Makefile.common
		LWIP_LOCAL_DIR := $(dir $(lastword $(MAKEFILE_LIST)))

		LWIPOPTS_DIR ?= include/default-opts
		LWIPPORT_DIR ?= include/

	state->serialat_fn = "/dev/ttyACM0";
	/* TODO: return error if device path is not found in cfg */
	state->serialat_fn = "/dev/ttyacm1";

	sys_arch_sem_wait(&(state->sem),0);
	sys_arch_sem_wait(&(state->sem), 0);

	#define MEMP_NUM_SYS_TIMEOUT 8
	#define MEMP_NUM_SYS_TIMEOUT 8

albertbog/host_port #76

Are you sure you want to change the base?

albertbog/host_port #76

Conversation

albertbog commented Sep 20, 2022

Description

Motivation and Context

Types of changes

How Has This Been Tested?

Checklist:

Special treatment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Sep 20, 2022

Choose a reason for hiding this comment

github-actions bot Sep 20, 2022

Choose a reason for hiding this comment

github-actions bot Sep 20, 2022

Choose a reason for hiding this comment

github-actions bot Sep 20, 2022

Choose a reason for hiding this comment

github-actions bot Sep 20, 2022

Choose a reason for hiding this comment

github-actions bot Sep 20, 2022

Choose a reason for hiding this comment

github-actions bot Sep 20, 2022

Choose a reason for hiding this comment

github-actions bot Sep 20, 2022

Choose a reason for hiding this comment

github-actions bot Sep 20, 2022

Choose a reason for hiding this comment

github-actions bot Sep 20, 2022

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Sep 20, 2022

Choose a reason for hiding this comment

github-actions bot Sep 20, 2022

Choose a reason for hiding this comment

github-actions bot Sep 20, 2022

Choose a reason for hiding this comment

github-actions bot Sep 20, 2022

Choose a reason for hiding this comment

github-actions bot Sep 20, 2022

Choose a reason for hiding this comment

github-actions bot Sep 20, 2022

Choose a reason for hiding this comment

github-actions bot Sep 20, 2022

Choose a reason for hiding this comment

github-actions bot Sep 20, 2022

Choose a reason for hiding this comment

github-actions bot Sep 20, 2022

Choose a reason for hiding this comment

github-actions bot Sep 20, 2022

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Sep 20, 2022

Choose a reason for hiding this comment

github-actions bot Sep 20, 2022

Choose a reason for hiding this comment

github-actions bot Sep 20, 2022

Choose a reason for hiding this comment

github-actions bot Sep 20, 2022

Choose a reason for hiding this comment

github-actions bot Sep 20, 2022

Choose a reason for hiding this comment

github-actions bot Sep 20, 2022

Choose a reason for hiding this comment

github-actions bot Sep 20, 2022

Choose a reason for hiding this comment

github-actions bot Sep 20, 2022

Choose a reason for hiding this comment

github-actions bot Sep 20, 2022

Choose a reason for hiding this comment

github-actions bot Sep 20, 2022

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Sep 28, 2022