drivers/imx-enet: Add support for ethernet in imxrt1064-evk #96

julianuziemblo · 2024-08-26T08:56:06Z

Description

Add Ethernet support for iMX RT106x, merging the code with existing driver for iMX RT6UL/6ULL in drivers/imx-enet.c

Motivation and Context

https://jira.phoenix-rtos.com/browse/RTOS-507

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

Already covered by automatic testing.
New test added: (add PR link here).
Tested by hand on: armv7a7-imx6ull-evk, armv7m7-imxrt106x-evk, armv7a7-imx6ull-dataro.

Checklist:

My change requires a change to the documentation.
I have updated the documentation accordingly.
I have added tests to cover my changes.
All new and existing linter checks and tests passed.
My changes generate no new compilation warnings for any of the targets.

Special treatment

This PR needs additional PRs to work:
I will merge this PR by myself when appropriate.

drivers/enet.c

drivers/enet.h

drivers/imx-enet.h

nalajcie

Partial review as current commit structure prevents efficient code review (the browser crashed with the amount of changes/comments in single commit :)).

Short summary:

fix commit message titles (see git history for examples), at least prefix them with module name (also include in commit message bodies what / why was changed), add missing JIRA ID
clearly split the changes into separate atomic commits (eg. changing type name is not bringing new functionality and should be a separate change)
fix coding style (according to our coding convention / MISRA as described in some comments)
please test the code after changes on imx6ull-evk and DTR project (from CI I see that something is broken there), check also if the performance is not degraded

_targets/Makefile.armv7a7-imx6ull

drivers/bdring.h

drivers/ephy.c

drivers/pktmem.c

drivers/imx-enet.c

drivers/ephy.c

github-actions · 2024-09-04T08:17:25Z

Unit Test Results

7 725 tests +25 7 008 ✅ +23 39m 0s ⏱️ + 1m 40s
445 suites + 9 715 💤 ± 0
1 files ± 0 2 ❌ + 2

For more details on these failures, see this check.

Results for commit bfbf6e1. ± Comparison against base commit 4896655.

This pull request removes 1 and adds 26 tests. Note that renamed tests count towards both.

phoenix-rtos-tests/proc/test_thread_rand ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/proc/test_thread_rand.threads_rand.test_1

phoenix-rtos-tests/mem/mmap ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/mem/mmap.test_mmap.len__not_page_aligned
phoenix-rtos-tests/mem/mmap ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/mem/mmap.test_mmap.len__not_page_aligned_file
phoenix-rtos-tests/mem/mmap ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/mem/mmap.test_mmap.len__zero
phoenix-rtos-tests/mem/mmap ‑ armv7a9-zynq7000-qemu:phoenix-rtos-tests/mem/mmap.test_mmap.len__not_page_aligned
phoenix-rtos-tests/mem/mmap ‑ armv7a9-zynq7000-qemu:phoenix-rtos-tests/mem/mmap.test_mmap.len__not_page_aligned_file
phoenix-rtos-tests/mem/mmap ‑ armv7a9-zynq7000-qemu:phoenix-rtos-tests/mem/mmap.test_mmap.len__zero
phoenix-rtos-tests/mem/mmap ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/mem/mmap.test_mmap.len__not_page_aligned
phoenix-rtos-tests/mem/mmap ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/mem/mmap.test_mmap.len__not_page_aligned_file
phoenix-rtos-tests/mem/mmap ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/mem/mmap.test_mmap.len__zero
phoenix-rtos-tests/mem/mmap ‑ armv7m4-stm32l4x6-nucleo:phoenix-rtos-tests/mem/mmap.test_mmap.len__not_page_aligned
…

♻️ This comment has been updated with latest results.

drivers/bdring.c

drivers/imx-enet-regs.h

drivers/imx-enet.c

nalajcie · 2024-09-13T11:23:59Z

converting to draft until it will be ready for next review

drivers/pktmem.c

nalajcie

pointed out further issues with the code.

❗ Please confirm that the code was tested on DTR platform (change the PR to draft until then).

Please split into more (smaller, atomic) commits. Every potentially-breaking change needs to be in separate commit - clearly describing WHY it's needed

Please fix commit messages:

be more concrete specifying the module in commit message title - here it will mostly be drivers/imx-enet or drivers - don't list all the files changed (that's what git is for)
for fixup comment - write in commit WHAT you're fixing, not WHICH commit (I need to dig further to learn what has actually changed), add info about the commit fixed in commit message body
add newline after commit message body and before the trailers

drivers/gpio.h

drivers/imx-enet-regs.h

drivers/imx-enet.c

drivers/imx-enet-regs.h

drivers/imx-enet.c

drivers/pktmem.c

JIRA: RTOS-507

change code style to match coding conventions JIRA: RTOS-507

refactor printfs with repeated format pattern into ephy_printf JIRA: RTOS-507

JIRA: RTOS-507

first step to add separate implementation files for imx6ull and imxrt106x gpio JIRA: RTOS-507

JIRA: RTOS-507

remove active value inversion in gpio_wait because the value is already being inverted in gpio_get JIRA: RTOS-507

JIRA: RTOS-507

fix 7b90e8e: - add _Atomic specifier to volatile vars used as atomics - change operations on the vars to atomic_* JIRA: RTOS-507

drivers/pktmem.c

fix packet buffer handling for targets with page size less than packet buffer size JIRA: RTOS-507

github-actions bot reviewed Aug 26, 2024

View reviewed changes

julianuziemblo force-pushed the julianuziemblo/enet-imxrt1064-evk branch from 3185e73 to a582983 Compare August 26, 2024 12:09

julianuziemblo force-pushed the julianuziemblo/enet-imxrt1064-evk branch 3 times, most recently from b8059e4 to 2af33ab Compare September 3, 2024 12:58

github-actions bot reviewed Sep 3, 2024

View reviewed changes

drivers/imx-enet.h Outdated Show resolved Hide resolved

drivers/imx-enet.h Outdated Show resolved Hide resolved

julianuziemblo force-pushed the julianuziemblo/enet-imxrt1064-evk branch from 2af33ab to f5e973e Compare September 3, 2024 13:01

github-actions bot reviewed Sep 3, 2024

View reviewed changes

drivers/imx-enet.h Outdated Show resolved Hide resolved

phoenix-rtos deleted a comment from github-actions bot Sep 3, 2024

nalajcie requested changes Sep 3, 2024

View reviewed changes

julianuziemblo force-pushed the julianuziemblo/enet-imxrt1064-evk branch from f5e973e to 7dbbd7e Compare September 4, 2024 08:03

julianuziemblo requested a review from Darchiv September 6, 2024 10:03

julianuziemblo force-pushed the julianuziemblo/enet-imxrt1064-evk branch from 7dbbd7e to 710b1d1 Compare September 6, 2024 14:57

github-actions bot reviewed Sep 6, 2024

View reviewed changes

drivers/bdring.c Outdated Show resolved Hide resolved

github-actions bot reviewed Sep 6, 2024

View reviewed changes

drivers/imx-enet-regs.h Outdated Show resolved Hide resolved

drivers/imx-enet-regs.h Outdated Show resolved Hide resolved

drivers/imx-enet-regs.h Outdated Show resolved Hide resolved

drivers/imx-enet-regs.h Show resolved Hide resolved

julianuziemblo force-pushed the julianuziemblo/enet-imxrt1064-evk branch 2 times, most recently from e11d5db to 067dc1b Compare September 6, 2024 15:10

github-actions bot reviewed Sep 6, 2024

View reviewed changes

drivers/imx-enet.c Outdated Show resolved Hide resolved

julianuziemblo force-pushed the julianuziemblo/enet-imxrt1064-evk branch 3 times, most recently from 8c41250 to fc32052 Compare September 10, 2024 10:19

nalajcie marked this pull request as draft September 13, 2024 11:23

julianuziemblo force-pushed the julianuziemblo/enet-imxrt1064-evk branch from fc32052 to f42a4cc Compare September 16, 2024 08:11

github-actions bot reviewed Sep 16, 2024

View reviewed changes

drivers/pktmem.c Outdated Show resolved Hide resolved

julianuziemblo force-pushed the julianuziemblo/enet-imxrt1064-evk branch 2 times, most recently from 23199d4 to 949cbf1 Compare September 16, 2024 08:29

github-actions bot reviewed Sep 16, 2024

View reviewed changes

drivers/pktmem.c Outdated Show resolved Hide resolved

julianuziemblo force-pushed the julianuziemblo/enet-imxrt1064-evk branch from 949cbf1 to c11c661 Compare September 16, 2024 08:31

julianuziemblo force-pushed the julianuziemblo/enet-imxrt1064-evk branch 3 times, most recently from b05a49a to ccc4d77 Compare September 17, 2024 11:39

julianuziemblo marked this pull request as ready for review September 17, 2024 11:55

julianuziemblo requested a review from nalajcie September 17, 2024 11:55

nalajcie requested changes Sep 23, 2024

View reviewed changes

julianuziemblo marked this pull request as draft September 23, 2024 12:58

julianuziemblo mentioned this pull request Sep 26, 2024

_projects/(imx6ull, imxrt106x): Add config for iMX ENET driver phoenix-rtos/phoenix-rtos-project#1134

Open

14 tasks

julianuziemblo changed the title ~~Add support for ethernet in imxrt1064-evk~~ drivers/imx-enet: Add support for ethernet in imxrt1064-evk Sep 26, 2024

Julian Uziemblo and others added 10 commits September 27, 2024 10:07

drivers/imx6-enet: rename files

f551649

JIRA: RTOS-507

drivers: fix code style

88c3e79

change code style to match coding conventions JIRA: RTOS-507

drivers/ephy: add ephy_printf

2a71fef

refactor printfs with repeated format pattern into ephy_printf JIRA: RTOS-507

drivers/imx-enet: fix possible integer overflow

c580074

JIRA: RTOS-507

drivers/gpio: put all gpio functionality into gpio.c

9f52a47

first step to add separate implementation files for imx6ull and imxrt106x gpio JIRA: RTOS-507

drivers/gpio: rename file

da57e68

JIRA: RTOS-507

drivers/imx6ull-gpio: fix gpio_wait

0f388c6

remove active value inversion in gpio_wait because the value is already being inverted in gpio_get JIRA: RTOS-507

drivers/imx-enet: Add support for ethernet in imxrt1064-evk

5b13ac0

JIRA: RTOS-507

drivers/gpio: add gpio functionality for imxrt106x

1ad819c

JIRA: RTOS-507

drivers/(bdring, imx-enet): fix atomic semantics

c44098d

fix 7b90e8e: - add _Atomic specifier to volatile vars used as atomics - change operations on the vars to atomic_* JIRA: RTOS-507

julianuziemblo force-pushed the julianuziemblo/enet-imxrt1064-evk branch from ccc4d77 to b4be4d5 Compare October 3, 2024 15:28

github-actions bot reviewed Oct 3, 2024

View reviewed changes

drivers/pktmem.c Outdated Show resolved Hide resolved

drivers/pktmem.c Outdated Show resolved Hide resolved

drivers/pktmem: fix allocPktBuf and freePktBuf

bfbf6e1

fix packet buffer handling for targets with page size less than packet buffer size JIRA: RTOS-507

julianuziemblo force-pushed the julianuziemblo/enet-imxrt1064-evk branch from b4be4d5 to bfbf6e1 Compare October 3, 2024 15:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

drivers/imx-enet: Add support for ethernet in imxrt1064-evk #96

drivers/imx-enet: Add support for ethernet in imxrt1064-evk #96

julianuziemblo commented Aug 26, 2024 •

edited

Loading

nalajcie left a comment

github-actions bot commented Sep 4, 2024 •

edited

Loading

nalajcie commented Sep 13, 2024

nalajcie left a comment

drivers/imx-enet: Add support for ethernet in imxrt1064-evk #96

Are you sure you want to change the base?

drivers/imx-enet: Add support for ethernet in imxrt1064-evk #96

Conversation

julianuziemblo commented Aug 26, 2024 • edited Loading

Description

Motivation and Context

Types of changes

How Has This Been Tested?

Checklist:

Special treatment

nalajcie left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 4, 2024 • edited Loading

Unit Test Results

nalajcie commented Sep 13, 2024

nalajcie left a comment

Choose a reason for hiding this comment

julianuziemblo commented Aug 26, 2024 •

edited

Loading

github-actions bot commented Sep 4, 2024 •

edited

Loading