Add posix tests (waiting for lsb_vsx port merge) #126
+609
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
adamdebek
force-pushed
the
adamdebek/lsb_vsx_tests
branch
from
1cdcd0d
to
5f8d4b9
Compare
adamdebek
force-pushed
the
adamdebek/lsb_vsx_tests
branch
from
5f8d4b9
to
1241441
Compare
damianloew
changed the title
adamdebek
force-pushed
the
adamdebek/lsb_vsx_tests
branch
from
1241441
to
7682eef
Compare
adamdebek
force-pushed
the
adamdebek/lsb_vsx_tests
branch
5 times, most recently
from
db28779
to
914851e
Compare
adamdebek
force-pushed
the
adamdebek/lsb_vsx_tests
branch
from
914851e
to
2483a3a
Compare
| test_name = [] | ||
| test_status = Status.OK | ||
|
|
||
| NAME = r'(.+?)Execute(.+?)T\.(?P<name>.+?)\r+\n' |
There was a problem hiding this comment.
Use one type of quotation mark in strings.
We mostly use black to format python code, which defaults to double quotation marks for strings. Basic use of tool is black -l 120 file_to_format.py
Suggested change
| NAME = r'(.+?)Execute(.+?)T\.(?P<name>.+?)\r+\n' | |
| NAME = r"(.+?)Execute(.+?)T\.(?P<name>.+?)\r+\n" |
Comment on lines
+39
to
+40
| if (line.find("IC") != -1 or line.find("TP") != -1 or line.find("TC") != -1 or line.find("Execute") != -1): | ||
| continue |
There was a problem hiding this comment.
I think it could be simplified.
Maybe something like this:
Suggested change
| if (line.find("IC") != -1 or line.find("TP") != -1 or line.find("TC") != -1 or line.find("Execute") != -1): | |
| continue | |
| if any(keyword in line for keyword in ["IC", "TP", "TC", "Execute"]): | |
| continue |
Also parentheses are not necessary with if
Suggested change
| if (line.find("IC") != -1 or line.find("TP") != -1 or line.find("TC") != -1 or line.find("Execute") != -1): | |
| continue | |
| if line.find("IC") != -1 or line.find("TP") != -1 or line.find("TC") != -1 or line.find("Execute") != -1: | |
| continue |
Comment on lines
+48
to
+49
| result = Result(name=test_name, status=Status.FAIL) | ||
| result.status = Status.FAIL |
There was a problem hiding this comment.
Why repeat code?
Suggested change
| result = Result(name=test_name, status=Status.FAIL) | |
| result.status = Status.FAIL | |
| result = Result(name=test_name, status=Status.FAIL) | |
| result = Result(name=test_name, status=Status.FAIL) | ||
| result.status = Status.FAIL | ||
|
|
||
| if (line.find("can't acquire exclusive lock") != -1): |
There was a problem hiding this comment.
Can be simplified
For example:
Suggested change
| if (line.find("can't acquire exclusive lock") != -1): | |
| if "can't acquire exclusive lock" in line: |
|
|
||
| if (line.find("can't acquire exclusive lock") != -1): | ||
| result.msg = '\t\t' + "can't acquire exclusive lock\n" | ||
| elif (line.find("can't exec") != -1): |
There was a problem hiding this comment.
Suggested change
| elif (line.find("can't exec") != -1): | |
| elif "can't exec" in line: |
| - name: T.tmpfile | ||
| execute: lsb_vsx_posix T.tmpfile | ||
| - name: T.tmpnam | ||
| ignore: True |
There was a problem hiding this comment.
If you know reasons for ignoring the test or if it is connected to the reported issue on github, you can leave a comment to provide information about that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add program to execute posix test suite
Motivation and Context
Types of changes
How Has This Been Tested?
Checklist:
Special treatment