Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ioctl test #191

Merged
merged 1 commit into from
Jul 6, 2023
Merged

add ioctl test #191

merged 1 commit into from
Jul 6, 2023

Conversation

adamdebek
Copy link
Contributor

@adamdebek adamdebek commented Apr 6, 2023

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

libc/test_ioctl.c Outdated Show resolved Hide resolved
libc/test_ioctl.c Outdated Show resolved Hide resolved
@adamdebek adamdebek changed the title Adamdebek/test ioctl add ioctl test Apr 6, 2023
@adamdebek adamdebek force-pushed the adamdebek/test_ioctl branch 7 times, most recently from c22848f to 0b9582e Compare April 12, 2023 10:39
@adamdebek adamdebek force-pushed the adamdebek/test_ioctl branch 4 times, most recently from 2de206c to 293e9dd Compare April 26, 2023 13:41
ioctl/test_ioctl.c Outdated Show resolved Hide resolved
ioctl/test_ioctl.c Outdated Show resolved Hide resolved
ioctl/test_ioctl.c Outdated Show resolved Hide resolved
ioctl/test_ioctl.c Outdated Show resolved Hide resolved
ioctl/test_ioctl.c Outdated Show resolved Hide resolved
ioctl/test_ioctl.c Outdated Show resolved Hide resolved
ioctl/test_ioctl.c Outdated Show resolved Hide resolved
ioctl/test_ioctl.c Outdated Show resolved Hide resolved
ioctl/test_ioctl.c Outdated Show resolved Hide resolved
ioctl/test_ioctl.c Outdated Show resolved Hide resolved
@adamdebek adamdebek force-pushed the adamdebek/test_ioctl branch 8 times, most recently from 1674ba2 to 0c449cf Compare May 29, 2023 16:17
ioctl/test_ioctl.c Outdated Show resolved Hide resolved
ioctl/test_ioctl.c Outdated Show resolved Hide resolved
ioctl/test_ioctl.c Outdated Show resolved Hide resolved
ioctl/test_ioctl.c Outdated Show resolved Hide resolved
ioctl/test_ioctl.c Outdated Show resolved Hide resolved
ioctl/test_ioctl.c Outdated Show resolved Hide resolved
ioctl/test_ioctl.c Outdated Show resolved Hide resolved
ioctl/test_ioctl.c Outdated Show resolved Hide resolved
ioctl/test_ioctl.c Outdated Show resolved Hide resolved
@adamdebek adamdebek force-pushed the adamdebek/test_ioctl branch 4 times, most recently from 7505426 to c03b291 Compare June 6, 2023 16:53
Copy link
Member

@nalajcie nalajcie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pointed out some issues which would make the code more readable ;).

ioctl/test_ioctl.c Outdated Show resolved Hide resolved
ioctl/test_ioctl.c Outdated Show resolved Hide resolved
ioctl/test_ioctl.c Outdated Show resolved Hide resolved
ioctl/test_ioctl.c Outdated Show resolved Hide resolved
ioctl/test_ioctl.c Outdated Show resolved Hide resolved
ioctl/test_ioctl.c Outdated Show resolved Hide resolved
ioctl/test_ioctl.c Outdated Show resolved Hide resolved
ioctl/test_ioctl.c Outdated Show resolved Hide resolved
ioctl/Makefile Outdated Show resolved Hide resolved
ioctl/test_ioctl.c Outdated Show resolved Hide resolved
@adamdebek adamdebek force-pushed the adamdebek/test_ioctl branch 2 times, most recently from a68baed to a1b8bfc Compare June 14, 2023 12:00
Copy link
Member

@nalajcie nalajcie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pointed out some other small things to be fixed

ioctl/test_ioctl.c Outdated Show resolved Hide resolved
ioctl/test_ioctl.c Outdated Show resolved Hide resolved
ioctl/test_ioctl.c Outdated Show resolved Hide resolved
ioctl/test_ioctl.c Outdated Show resolved Hide resolved
ioctl/test_ioctl.c Outdated Show resolved Hide resolved
ioctl/test_ioctl.c Outdated Show resolved Hide resolved
ioctl/test_ioctl.c Outdated Show resolved Hide resolved
Copy link
Contributor

@damianloew damianloew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the naming as it's recommended in the https://github.com/phoenix-rtos/phoenix-rtos-doc/blob/master/coding.md

ioctl/test_ioctl.c Outdated Show resolved Hide resolved
ioctl/test_ioctl.c Outdated Show resolved Hide resolved
ioctl/test_ioctl.c Outdated Show resolved Hide resolved
ioctl/test_ioctl.c Outdated Show resolved Hide resolved
ioctl/test_ioctl.c Outdated Show resolved Hide resolved
ioctl/test_ioctl.c Outdated Show resolved Hide resolved
ioctl/test_ioctl.c Outdated Show resolved Hide resolved
ioctl/test_ioctl.c Outdated Show resolved Hide resolved
ioctl/test_ioctl.c Outdated Show resolved Hide resolved
ioctl/test_ioctl.c Outdated Show resolved Hide resolved
@adamdebek adamdebek force-pushed the adamdebek/test_ioctl branch 6 times, most recently from b590f21 to 23fc7b0 Compare June 16, 2023 14:09
@adamdebek adamdebek force-pushed the adamdebek/test_ioctl branch 3 times, most recently from e5207bc to 16b273a Compare June 26, 2023 13:42
Copy link
Contributor

@damianloew damianloew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things more and I'd merge it.

ioctl/test_ioctl.c Outdated Show resolved Hide resolved
ioctl/test_ioctl.c Outdated Show resolved Hide resolved
@adamdebek adamdebek force-pushed the adamdebek/test_ioctl branch 2 times, most recently from 56f86f0 to 081a789 Compare June 27, 2023 12:30
damianloew
damianloew previously approved these changes Jun 27, 2023
Copy link
Contributor

@damianloew damianloew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is convention to name binaries using dash (test-name) as @nalajcie suggested some time ago. Now only the older tests, mainly those not supported by Unity are named with underscore. I know that it's also needed to name source file this way when using add_unity_test in Makefile, but still I'd do it this way.

JIRA: CI-237
@damianloew damianloew merged commit 1fc9591 into master Jul 6, 2023
24 checks passed
@damianloew damianloew deleted the adamdebek/test_ioctl branch July 6, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants