-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ioctl test #191
add ioctl test #191
Conversation
575a50e
to
24b9a27
Compare
c22848f
to
0b9582e
Compare
2de206c
to
293e9dd
Compare
1674ba2
to
0c449cf
Compare
0c449cf
to
29a1b1c
Compare
7505426
to
c03b291
Compare
cb64908
to
47ae11b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've pointed out some issues which would make the code more readable ;).
a68baed
to
a1b8bfc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pointed out some other small things to be fixed
a1b8bfc
to
78e2a7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use the naming as it's recommended in the https://github.com/phoenix-rtos/phoenix-rtos-doc/blob/master/coding.md
b590f21
to
23fc7b0
Compare
e5207bc
to
16b273a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two things more and I'd merge it.
56f86f0
to
081a789
Compare
cc60a7d
to
172f1b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is convention to name binaries using dash (test-name) as @nalajcie suggested some time ago. Now only the older tests, mainly those not supported by Unity are named with underscore. I know that it's also needed to name source file this way when using add_unity_test
in Makefile, but still I'd do it this way.
JIRA: CI-237
172f1b9
to
e713a42
Compare
Description
Motivation and Context
Types of changes
How Has This Been Tested?
Checklist:
Special treatment