libc: strchr tests: add test group for ASCII compare

[maska989]

Description

Added strcspn and strspn test cases

Motivation and Context

JIRA: CI-232

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

• Already covered by automatic testing.
• New test added: (add PR link here).
• Tested by hand on: (list targets here).

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing linter checks and tests passed.
• My changes generate no new compilation warnings for any of the targets.

Special treatment

• This PR needs additional PRs to work (list the PRs, preferably in merge-order).
• I will merge this PR by myself when appropriate.

[mateusz-bloch]

Thanks for this tests. I've pointed out some small nitpicks.

Also I would consider renaming the commit to more closely match the changes, and change beginning of the file:

 * TESTED:
 * 	- strlen()
 * 	- strnlen()
 *     -  strcspn()
 *     -  strspn()
 * 	- strchr()
 * 	- strrchr()
 * 	- memchr()

EDIT: You can also tidy up included files.
Aren't these all you need in this test ?:

#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <limits.h>
#include <unity_fixture.h>

[mateusz-bloch]

LGTM, don't forget to organize your commits before merge, also i would wait for @damianloew to approve

[damianloew]

@mateusz-bloch thanks for previous reviews and @maska989 for much cleaner code, a few things more to add/change.

[damianloew]

A few things more to improve, please look at the suggestions above.

[damianloew]

When naming it empty_output do you mean that 0 should be returned? If yes you can also add there strspn("abc", "") and strcspn("abc", "bc")

[damianloew]

Eventually it could be the case where empty arguments are checked, and then strcspn("abc", "") and strcspn("", "abc") should be tested.

[maska989]

strcspn("", "abc")

This element is present on commented lines.

[damianloew]

I don't know what was the intention, but if you want to have all ascii chars you have to set size to 129.

Please edit the description of this function in testdata.h:

/* 
 * for (size >= ALL_CHARS_STRING_SIZE) returns string filled with all possible chars.
 * for (size < ALL_CHARS_STRING_SIZE) returns string with the following content: {1,1,2,...(size-2),0}.
 * The returned pointer has to be freed after use!
 */
extern char *testdata_createCharStr(int size);

Would it be more readable?

[maska989]

It is done in #199