-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libc: fix nightly nucleo fail #223
Conversation
16995e4
to
ab15967
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can split those cases to decrease execution time for one test case.
libc/printf/stdio_printf.c
Outdated
static char *test_intToAscii(int value) | ||
{ | ||
char *str = malloc(2 * sizeof(char)); | ||
static char str[2]; | ||
str[0] = value; | ||
str[1] = '\0'; | ||
return str; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfornutately as it's mentioned in our coding convention:
https://github.com/phoenix-rtos/phoenix-rtos-doc/blob/master/coding.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So you can leave the previous approach.
JIRA CI-260
dcc8352
to
d1c9b37
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issue:
The following test cases have an extended execution time:
TEST(stdio_printf_cspn, c_ascii)
TEST(stdio_printf_cspn, c_non_ascii)
TEST(stdio_printf_cspn, s_ascii)
Description
Motivation and Context
Types of changes
How Has This Been Tested?
Checklist:
Special treatment