mem: add mprotect tests #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badochov
force-pushed
the
badochov/mprotect
branch
4 times, most recently
from
9af2b2a
to
0c0f8f7
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
badochov
force-pushed
the
badochov/mprotect
branch
from
0c0f8f7
to
c53ba48
Compare
maska989
force-pushed
the
badochov/mprotect
branch
from
140d703
to
4bd561a
Compare
badochov
force-pushed
the
badochov/mprotect
branch
from
4bd561a
to
1c9c822
Compare
badochov
force-pushed
the
badochov/mprotect
branch
from
1c9c822
to
1689639
Compare
badochov
force-pushed
the
badochov/mprotect
branch
from
1689639
to
3cb4110
Compare
Unit Test Results6 003 tests +1 5 362 ✔️ +1 30m 13s ⏱️ -40s Results for commit 329cb3a. ± Comparison against base commit 3905060. This pull request removes 7 and adds 8 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
agkaminski
reviewed
Nov 23, 2023
badochov
force-pushed
the
badochov/mprotect
branch
from
3cb4110
to
0ad330a
Compare
JIRA: RTOS-666
badochov
force-pushed
the
badochov/mprotect
branch
from
0ad330a
to
329cb3a
Compare
damianloew
reviewed
Dec 20, 2023
|
|
||
| TEST(test_mprotect, test_mprotect_singlecore) | ||
| { | ||
| unsigned char *area = mmap(NULL, page_size * PAGES, PROT_READ | PROT_WRITE, MAP_ANONYMOUS | MAP_PRIVATE, -1, 0); |
There was a problem hiding this comment.
Maybe it would be better to not set PROT_READ at the beginning to check whether read access protection has been set properly in the mprotect call.
There was a problem hiding this comment.
I wouldn't work then as we require that the protection required by the mrpotect has to be lesser or equal than the one established by mmap
|
|
||
| TEST_SETUP(test_mprotect) | ||
| { | ||
| page_size = sysconf(_SC_PAGESIZE); |
There was a problem hiding this comment.
We could get it once - at the beginning of a test (for example in runner()), not before all test cases, or alternatively only within the test case body.
There was a problem hiding this comment.
EDIT: I know that now we have only one test case, but when someone will add more of them it's easy to forget about it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: RTOS-666
Description
Add tests to new mprotect syscall.
Demo PR showing that tests pass with kernel and libphoenix changes applied.
phoenix-rtos/phoenix-rtos-project#922
Motivation and Context
Types of changes
How Has This Been Tested?
Checklist:
Special treatment
mprotect: add syscall phoenix-rtos-kernel#475
Add mprotect syscall libphoenix#311