trunner: armv7a9: provide soft restarts #305
Conversation
maska989
force-pushed
the
maska989/armv7a9_soft_restarts
branch
3 times, most recently
from
d7996bc
to
e9f10fb
Compare
JIRA: CI-389
maska989
force-pushed
the
maska989/armv7a9_soft_restarts
branch
from
e9f10fb
to
f184945
Compare
| @@ -109,6 +109,9 @@ def __call__(self, flash=False, hard=False): | |||
|
|
|||
| self._set_flash_mode(flash) | |||
|
|
|||
| # Ensuring that first up target will change state before restart | |||
| time.sleep(0.5) | |||
There was a problem hiding this comment.
From what I understand it's only needed on zynq target, so why do we add it in the common code?
There was a problem hiding this comment.
On other targets are no impact about that, because construction and way how they change states are different from zynq 7000. On other targets we can easily first up reboot and in this time change state. Zynq7000 need to have to change state as first because it prepares target for what is needed after reboot. I added this code there because it doesn't colidate with other targets and clarify situation with order in flashing state.
This is Reset cycle of zynq7000-zedboard:
And there is reason why Reboot is needed and what types of Signals can be needed in this situation:
| def _reboot_soft(self): | ||
| self._reboot_hard() | ||
| self.host.set_reset(0) | ||
| time.sleep(0.5) | ||
| self.dut.clear_buffer() | ||
| self.host.set_reset(1) | ||
| time.sleep(0.25) |
There was a problem hiding this comment.
It's already defined in the same form in the parent class, so you can just remove it just like it's done there: https://github.com/phoenix-rtos/phoenix-rtos-tests/blob/8c6d062c2fbd327e2664ec371fcf8bddf1135483/trunner/target/armv7m7.py#L21C14-L21C14
There was a problem hiding this comment.
@damianloew look closely on line 32. Same history like before. It needs more time to bring down the target.
JIRA: CI-389
Description
Motivation and Context
Types of changes
How Has This Been Tested?
Checklist:
Special treatment