Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libc: increase time limits in unix socket test #350

Merged
merged 1 commit into from
May 24, 2024

Conversation

adamdebek
Copy link
Contributor

JIRA: CI-452

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

Copy link

github-actions bot commented Apr 24, 2024

Unit Test Results

7 460 tests  ±0   6 745 ✅ +1   36m 59s ⏱️ - 1m 41s
  420 suites ±0     715 💤 ±0 
    1 files   ±0       0 ❌  - 1 

Results for commit 050b7cf. ± Comparison against base commit 04b1486.

♻️ This comment has been updated with latest results.

@nalajcie
Copy link
Member

  • maybe we should use TEST_ASSERT_LESS_THAN and other similar for integer comparison - so we would get the actual value on error (would make it easier to tune the values)
  • probably the constraints should be either per-target-family or different on emulated targets (where we don't expect even soft realtime?) - but that's a broader topic not to be breached right now

Copy link
Contributor

@damianloew damianloew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure whether the changed values will be 100% fine, but I'd opt for thinking about it in detail when you upload your next improvements in the separate commit.

@adamdebek adamdebek merged commit d592f9e into master May 24, 2024
30 checks passed
@adamdebek adamdebek deleted the adamdebek/socket-test-fix branch May 24, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants