Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libc/misc: add tests for libphoenix __safe_read/write functions #363

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

lukileczo
Copy link
Member

@lukileczo lukileczo commented Jul 29, 2024

JIRA: RTOS-882

Description

Add simple tests for libphoenix internal __safe_read/write functions.

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

agkaminski
agkaminski previously approved these changes Jul 29, 2024
Copy link
Member

@agkaminski agkaminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, perhaps we could also add __safe_open and __safe_close to the mix

Copy link

github-actions bot commented Jul 29, 2024

Unit Test Results

7 700 tests   6 977 ✅  37m 42s ⏱️
  436 suites    715 💤
    1 files        8 ❌

For more details on these failures, see this check.

Results for commit bb1be92.

♻️ This comment has been updated with latest results.

@lukileczo
Copy link
Member Author

LGTM, perhaps we could also add __safe_open and __safe_close to the mix

Done

@lukileczo lukileczo merged commit 21d61a7 into master Jul 29, 2024
21 of 30 checks passed
@lukileczo lukileczo deleted the lukileczo/rtos-882 branch July 29, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants