Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libc: re-enable tests for strtoll, strtoull #371

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jmaksymowicz
Copy link
Contributor

Also add test for strtol, etc. to test for case where "0x" prefix is not followed by a hex digit.

Description

Motivation and Context

Re-enable tests after fixes in phoenix-rtos/libphoenix#381

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

Copy link

github-actions bot commented Sep 9, 2024

Unit Test Results

7 732 tests  +9   7 009 ✅ + 1   36m 56s ⏱️ +10s
  443 suites ±0     699 💤  - 16 
    1 files   ±0      24 ❌ +24 

For more details on these failures, see this check.

Results for commit 1759513. ± Comparison against base commit 0cd1f36.

♻️ This comment has been updated with latest results.

Add test for strtol, etc. to test for case where "0x" prefix is not
followed by a hex digit.

JIRA: RTOS-869
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant