Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trunner: add sparcv8leon3-generic-qemu target support #372

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

trunner: add sparcv8leon3-generic-qemu target support #372

wants to merge 1 commit into from

Conversation

maska989
Copy link
Contributor

@maska989 maska989 commented Sep 18, 2024 •
edited
Loading

JIRA: CI-474

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (sparcv8leon3-generic-qemu).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

@nalajcie
Copy link
Member

regarding the commit message: this is not a name of any TaRgEt supported by phoenix-RTOS :P

damianloew
damianloew requested changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@damianloew damianloew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please enable this target to CI in a separate commit.

mem/test.yaml Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 18, 2024 •
edited
Loading

Unit Test Results

7 580 tests   - 143   6 865 ✅  - 143   16m 41s ⏱️ - 21m 3s
  300 suites  - 143     715 💤 ±  0 
    1 files   ±  0       0 ❌ ±  0 

Results for commit 2f114c5. ± Comparison against base commit a20b474.

This pull request removes 143 tests. 
phoenix-rtos-tests/psh/auth ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/psh/auth
phoenix-rtos-tests/psh/auth ‑ armv7a9-zynq7000-qemu:phoenix-rtos-tests/psh/auth
phoenix-rtos-tests/psh/auth ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/psh/auth
phoenix-rtos-tests/psh/auth ‑ armv7m4-stm32l4x6-nucleo:phoenix-rtos-tests/psh/auth
phoenix-rtos-tests/psh/auth ‑ armv7m7-imxrt106x-evk:phoenix-rtos-tests/psh/auth
phoenix-rtos-tests/psh/auth ‑ armv7m7-imxrt117x-evk:phoenix-rtos-tests/psh/auth
phoenix-rtos-tests/psh/auth ‑ ia32-generic-qemu:phoenix-rtos-tests/psh/auth
phoenix-rtos-tests/psh/auth ‑ riscv64-generic-qemu:phoenix-rtos-tests/psh/auth
phoenix-rtos-tests/psh/autocompletion ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/psh/autocompletion
phoenix-rtos-tests/psh/autocompletion ‑ armv7a9-zynq7000-qemu:phoenix-rtos-tests/psh/autocompletion
…

♻️ This comment has been updated with latest results.

@maska989 maska989 force-pushed the maska989/add_Sparcv8Leon3_General_support branch from 8f3e1a7 to c141281 Compare September 18, 2024 08:59
@maska989 maska989 changed the title trunner: add Sparcv8Leon3_Generic target support trunner: add sparcv8leon3-generic-qemu target support Sep 18, 2024
@maska989 maska989 force-pushed the maska989/add_Sparcv8Leon3_General_support branch 2 times, most recently from 24427c5 to b33c810 Compare September 18, 2024 09:15
mateusz-bloch
mateusz-bloch reviewed Sep 18, 2024
View reviewed changes
Copy link
Member

@mateusz-bloch mateusz-bloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When building with tests option

LD  test_mmap               
/src/phoenix-rtos-tests/devices/grlib-multi/test-grlib-multi.c:28:2: error: #error "Unsupported target"
   28 | #error "Unsupported target"
      |  ^~~~~
/src/phoenix-rtos-tests/devices/grlib-multi/test-grlib-multi.c:31:10: fatal error: grlib-multi.h: No such file or directory
   31 | #include <grlib-multi.h>
      |          ^~~~~~~~~~~~~~~
compilation terminated.
make: *** [../phoenix-rtos-build/Makefile.common:211: /src/_build/sparcv8leon3-generic-qemu/phoenix-rtos-tests/devices/grlib-multi/test-grlib-multi.o] Error 1
make: *** Waiting for unfinished jobs....

@maska989 maska989 force-pushed the maska989/add_Sparcv8Leon3_General_support branch from b33c810 to f515cfb Compare September 18, 2024 10:53
@mateusz-bloch
Copy link
Member

When building with tests option

LD  test_mmap               
/src/phoenix-rtos-tests/devices/grlib-multi/test-grlib-multi.c:28:2: error: #error "Unsupported target"
   28 | #error "Unsupported target"
      |  ^~~~~
/src/phoenix-rtos-tests/devices/grlib-multi/test-grlib-multi.c:31:10: fatal error: grlib-multi.h: No such file or directory
   31 | #include <grlib-multi.h>
      |          ^~~~~~~~~~~~~~~
compilation terminated.
make: *** [../phoenix-rtos-build/Makefile.common:211: /src/_build/sparcv8leon3-generic-qemu/phoenix-rtos-tests/devices/grlib-multi/test-grlib-multi.o] Error 1
make: *** Waiting for unfinished jobs....

You could add this to the Makefile.sparcvleon3, or come up with better solution

ifneq ($(TARGET), sparcv8leon3-generic-qemu)
DEFAULT_COMPONENTS += test-grlib-multi
endif

mateusz-bloch
mateusz-bloch reviewed Sep 18, 2024
View reviewed changes
psh/test.yaml
@@ -13,7 +13,7 @@ test:
- name: pshlogin
harness: test-pshlogin.py
targets:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the beginning of yaml should be smth like:

test:
    targets:
      #TODO: remove when sparcv8leon3-generic-qemu target will stop being experimental
      include: [sparcv8leon3-generic-qemu]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not done

@maska989 maska989 force-pushed the maska989/add_Sparcv8Leon3_General_support branch 2 times, most recently from 1d3be02 to 65d206a Compare September 23, 2024 14:03
mateusz-bloch
mateusz-bloch reviewed Sep 23, 2024
View reviewed changes
Makefile.sparcv8leon3
DEFAULT_COMPONENTS += test-grlib-multi
endif
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no newline at the end of file

mem/test.yaml Outdated Show resolved Hide resolved
mem/test.yaml Outdated Show resolved Hide resolved
psh/test.yaml
@@ -13,7 +13,7 @@ test:
- name: pshlogin
harness: test-pshlogin.py
targets:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not done

trunner/target/emulated.py Outdated Show resolved Hide resolved
@maska989 maska989 force-pushed the maska989/add_Sparcv8Leon3_General_support branch 2 times, most recently from c44e91e to baa8005 Compare September 26, 2024 08:43
@maska989 maska989 force-pushed the maska989/add_Sparcv8Leon3_General_support branch from baa8005 to 2f114c5 Compare September 26, 2024 11:00
mateusz-bloch
mateusz-bloch reviewed Sep 27, 2024
View reviewed changes
psh/test.yaml
@@ -1,4 +1,7 @@
test:
targets:
value: [sparcv8leon3-generic-qemu]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should include target, not set sparcv8leon3-generic-qemu as only target, also comment should be place why it is done.

Suggested change
value: [sparcv8leon3-generic-qemu]
include: [sparcv8leon3-generic-qemu]

damianloew
damianloew reviewed Oct 2, 2024
View reviewed changes
Makefile.sparcv8leon3
@@ -1 +1,3 @@
ifneq ($(TARGET), sparcv8leon3-generic-qemu)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's the simplest solution possible here, but let's leave a comment that we don't want to build this test for qemu architecture and why (please ask an author for a reason).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could also do this in a separate commit and be connected to this issue: phoenix-rtos/phoenix-rtos-project#1182

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it should be done in the separate commit for sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damianloew damianloew damianloew requested changes

@mateusz-bloch mateusz-bloch mateusz-bloch left review comments

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maska989 @nalajcie @mateusz-bloch @damianloew