trunner: add multi possible device search for targets #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maska989
force-pushed
the
maska989/vid_pid_parser
branch
from
d8b023b
to
a750e03
Compare
Comment on lines
+29
to
+36
| all_ports = list_ports.comports() | ||
| vid_pid_list = vid_pid_parser(port_hint) | ||
| ports = [] | ||
|
|
||
| for port in all_ports: | ||
| for vid, pid in vid_pid_list: | ||
| if port.vid == vid and port.pid == pid: | ||
| ports.append(port) |
There was a problem hiding this comment.
Suggested change
| all_ports = list_ports.comports() | |
| vid_pid_list = vid_pid_parser(port_hint) | |
| ports = [] | |
| for port in all_ports: | |
| for vid, pid in vid_pid_list: | |
| if port.vid == vid and port.pid == pid: | |
| ports.append(port) | |
| vid_pid_list = vid_pid_parser(port_hint) | |
| ports = [port for port in list_ports.comports() if (port.vid, port.pid) in vid_pid_list] |
There was a problem hiding this comment.
It seems to be simple, so I'd prefer to use this version
maska989
force-pushed
the
maska989/vid_pid_parser
branch
from
a750e03
to
8efe664
Compare
damianloew
requested changes
Oct 4, 2024
| def find_port(port_hint: str) -> str: | ||
| port = None | ||
|
|
||
| for p in list_ports.grep(port_hint): |
There was a problem hiding this comment.
After some thinking, we can simply pass a part of port name, which is correct for both older and newer board. For older the device string from list_ports() is:
/dev/ttyACM0 - DAPLink CMSIS-DAP - mbed Serial Port
for newer one:
/dev/ttyACM0 - MCU-LINK on-board (r0E2) CMSIS-DAP V2.250 - VCOM
So I propose looking for CMSIS-DAP for armv7m7 targets. Then all this additional code is not needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: CI-500
Description
In replace target to new version, there was problem with new device ID and vendor ID.
That means we are forced to replace it in target variables, but we want also have the possibility to run older versions of the boards. That's why we want to utilize multiple possible vid/pid configuration to the same target.
Motivation and Context
Types of changes
How Has This Been Tested?
Checklist:
Special treatment