Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quick-fix: add support for tab character in ia32 tty-bios #277

Merged
merged 1 commit into from
Aug 23, 2023
Merged

quick-fix: add support for tab character in ia32 tty-bios #277

merged 1 commit into from
Aug 23, 2023

Conversation

gerard5
Copy link
Contributor

@gerard5 gerard5 commented Aug 23, 2023

The tty-bios (a.k.a. vga-console) was missing \t support.

Before:
2023-08-23-140733_1346x461_scrot

After (fixed):
2023-08-23-140621_1405x460_scrot

JIRA: RTOS-568

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: ia32-generic (VGA).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@gerard5 gerard5 self-assigned this Aug 23, 2023
agkaminski
agkaminski approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

@agkaminski agkaminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gerard5 gerard5 merged commit 8b999ce into master Aug 23, 2023
25 checks passed
@gerard5 gerard5 deleted the gerard5/RTOS-568 branch August 23, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agkaminski agkaminski agkaminski approved these changes

Assignees

@gerard5 gerard5

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gerard5 @agkaminski