Adds mounts to fly backend #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Quick update. Apparently the volumeId is a required field, so i'm going to work on a change to this to grab a volumeId from existing un-attached volumes with matching names, and use those ids to build the mounts array |
|
Alright, now the fly backend will attempt to find a volumeId that matches the name specified in the mounts config option. If it finds enough it'll add those ids in as This gets around the 500 that's thrown by fly if you don't include the volume id. |
mruoss
reviewed
Dec 27, 2023
|
These are great suggestions! I'll get them in tomorrow |
|
@benbot could this be updated to resolve conflicts? I'd love to see this merged in to the latest! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on getting some elastic LLM inference set up using phoenix, fly, and FLAME and needed volumes attached to my flame workers so that I don't need to download an 8gb+ model on startup.
I added support for the
mountsfield in the machines api (https://fly.io/docs/machines/working-with-machines/)Though it seems like fly has a bug where this isn't working right now. I keep getting 500s when passing in that argument. I made a thread on their forum to track it
https://community.fly.io/t/machine-api-returning-500-when-passing-in-mounts/17336