Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode support for code reloader error pages #5776

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jonnytest1
Copy link

@jonnytest1 jonnytest1 commented Apr 8, 2024

could use some thoughts on which colors to pick but hey its dark ^^

image

@ryanwinchester
Copy link

The text needs some more contrast but this would be very helpful while streaming programming so as to not flashbang viewers

@03juan
Copy link
Contributor

03juan commented Apr 8, 2024

I think @style.accent also should be tweaked.

@03juan
Copy link
Contributor

03juan commented Apr 8, 2024

Alternatively, also provide configurable assigns for background colors, and let users override it by implementing their own debug handler and passing custom fg, bg, accent, etc. colors

@jonnytest1
Copy link
Author

jonnytest1 commented Apr 8, 2024

yeah should definitely be configurable since the other colors are , it would be very counterintuitive if the defined color isnt the one displayed

alternative

filter: invert(1);

can also be considered (another invert(1) for the logo to be orange again )

image

@rhcarvalho
Copy link
Contributor

Hi @jonnytest1 💜

Considering the code changes, I'd suggest updating the title of the PR to help the Phoenix team more quickly understand the scope when triaging the open PRs. E.g.: "Dark mode support for code reloader error pages".

@jonnytest1 jonnytest1 changed the title added dark mode Dark mode support for code reloader error pages May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants