Send download encodes reserved chars #5928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mcrumm
commented
Sep 6, 2024
mcrumm
commented
- Closes Error when using send_download/3 with a filename that contains spaces and commas #5926
Gazler
approved these changes
Sep 10, 2024
| @@ -537,6 +537,17 @@ defmodule Phoenix.Controller.ControllerTest do | |||
| "world" | |||
| end | |||
|
|
|||
| test "issue #5926, sends file for download for filename with unreserved characters" do | |||
There was a problem hiding this comment.
I don't think we usually include the issue # in the test name.
mcrumm
commented
Sep 10, 2024
|
💚 💙 💜 💛 ❤️ |
|
It looks like this still hasn't been released. Is there anything blocking this from being released? |
|
@ftes there are a lot of changes on main that are waiting for 1.8. We're planning to focus on the missing pieces in the next couple of weeks. For now, we haven't planned to do another 1.7 release, but maybe we should? @josevalim |
|
I didn't backport this on purpose to v1.7 because people could be relying on the old behaviour for some reason, even if buggy. So you can either prune it yourself, use main, or wait until v1.8 is out :) |
|
Thanks for the update! Workaround in user land: filename = URI.encode(filename, &URI.char_unreserved?/1)
send_download(conn, {:binary, body}, filename: filename, encode: false) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.