Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove an old test file from the installer #5939

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

JonRowe
Copy link
Contributor

@JonRowe JonRowe commented Sep 25, 2024

👋 I found this file whilst looking through the installer templates, it appears not to be referenced anywhere and would never pass unless I'm missing something in a freshly generated app, was it left behind from #4431?

@SteffenDE SteffenDE merged commit d00f197 into phoenixframework:main Sep 25, 2024
7 checks passed
@SteffenDE
Copy link
Contributor

I think you're completely right :)
Good catch, thank you! 🙌🏻

@JonRowe JonRowe deleted the remove-old-test-file branch September 25, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants