Add LiveViewTest.assert_* macros to locals_without_parens config #5991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So one can simply add `:phoenix` to their `:plugins` option in `.formatter.exs` and it will not automatically include parens to those functions when `mix format`ing
SteffenDE
reviewed
Nov 29, 2024
There was a problem hiding this comment.
Please also add refute_push_event/4 (phoenixframework/phoenix_live_view#3490)
.formatter.exs
Outdated
| assert_redirect: 2, | ||
| assert_redirect: 3, | ||
| assert_redirected: 2, | ||
| assert_reply: 3 |
There was a problem hiding this comment.
We already have assert_reply/3 in line 53. I don't know if duplicates are a problem though.
There was a problem hiding this comment.
As for duplicates, they shouldn't affect the code, as the function that checks them will work the same (it basically just Enum.any? this list here: https://github.com/elixir-lang/elixir/blob/44107f1010229f58d899177e34eb04357a075ab3/lib/elixir/lib/code/formatter.ex#L180-L185
IMO we should leave it here, just in case someday someone removes one of these sections.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So one can simply add
:phoenixto their:pluginsoption in.formatter.exsand it will not automatically include parens to those functions whenmix formatingOriginal PR phoenixframework/phoenix_live_view#3535