Push pending events before redirecting #2923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
approved these changes
Nov 17, 2023
josevalim
reviewed
Nov 17, 2023
| @@ -837,6 +841,11 @@ defmodule Phoenix.LiveView.Channel do | |||
| end | |||
| end | |||
|
|
|||
| defp push_pending_events_on_redirect(state, socket) do | |||
There was a problem hiding this comment.
Consider moving this function to the Diff module.
There was a problem hiding this comment.
I think the function makes sense here because it depends on push maybe we could add a get_push_events function to Diff which returns either {"diff", %{e: events}} or nil?
Presumably the goal here is to avoid the duplication of "diff" and @events?
There was a problem hiding this comment.
Yeah. get_push_events sounds good to me!
There was a problem hiding this comment.
Gazler
force-pushed
the
gr-push-events-on-redirect
branch
from
4cf29a0 to
8aa91ac
Compare
Previously, there was no way to handle both `push_event` and `push_redirect` occuring in the same callback. The redirect would prevent the events from being sent. This commit checks the diff for any new events, and if they exist, sends them over the channel.
Gazler
force-pushed
the
gr-push-events-on-redirect
branch
from
8aa91ac to
ec3566e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, there was no way to handle both
push_eventandpush_redirectoccuring in the same callback. The redirect would prevent the events from being sent. This commit checks the diff for any new events, and if they exist, sends them over the channel.