remove replaceRootHistory #3625
Open
+79
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relates to: #3529 `replaceRootHistory` was initially added by @josevalim in 36edb48, but lost its purpose after less than three months with 04aaedc removing the only call that would actually set `root: true` in the history state. Me not knowing what `root: true` is supposed to do reused replaceRootHistory in #3335, reintroducing the case where `root: true`` is set in the history state. While #3335 was reverted later due to issues (#3508), I reworked the back/forward navigation problem in #3539, which again used `replaceRootHistory`. As `root: true` would now be set in the history, we'd call `replaceRootHistory` on live navigation. The problem is that it was setting `type: "patch"` in the history, which leads to LiveView assuming that it can patch when navigating using popstate, while the actual navigation was `type: "navigate"`. After looking into it, I don't really see a reason for replaceRootHistory to exist any more.
SteffenDE
force-pushed
the
sd-remove-replace-root-history
branch
from
94b2df3 to
2ef54e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to: #3529
Relates to: #3624
replaceRootHistorywas initially added by @chrismccord in 36edb48, but lost its purpose after less than three months with 04aaedc removing the only call that would actually setroot: truein the history state.Me not knowing what
root: trueis supposed to do reused replaceRootHistory in #3335, reintroducing the case whereroot: trueis set in the history state. While #3335 was reverted later due to issues (#3508), I reworked the back/forward navigation problem in#3539, which again used
replaceRootHistory. Asroot: truewould now be set in the history, we'd callreplaceRootHistoryon live navigation. The problem is that it was settingtype: "patch"in the history, which leads to LiveView assuming that it can patch when navigating using popstate, while the actual navigation wastype: "navigate". After looking into it, I don't really see a reason for replaceRootHistory to exist any more.