Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

properly clear viewHooks when destroying a hook #3628

Merged
merged 1 commit into from
Jan 11, 2025
Merged

properly clear viewHooks when destroying a hook #3628

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion assets/js/phoenix_live_view/view.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -725,9 +725,12 @@ export default class View {
}

destroyHook(hook){
// __destroyed clears the elementID from the hook, therefore
// we need to get it before calling __destroyed
const hookId = ViewHook.elementID(hook.el)
hook.__destroyed()
hook.__cleanup__()
delete this.viewHooks[ViewHook.elementID(hook.el)]
delete this.viewHooks[hookId]
}

applyPendingUpdates(){
Expand Down
2 changes: 2 additions & 0 deletions assets/test/view_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -832,6 +832,7 @@ describe("View Hooks", function(){
liveview_version
})
expect(view.el.firstChild.innerHTML).toBe("TEST MOUNT")
expect(Object.keys(view.viewHooks)).toHaveLength(1)

view.update({
s: ["<h2 id=\"up\" phx-hook=\"Upcase\">test update</h2>"],
Expand All @@ -849,6 +850,7 @@ describe("View Hooks", function(){
view.update({s: ["<div></div>"], fingerprint: 123}, [])
expect(upcaseWasDestroyed).toBe(true)
expect(hookLiveSocket).toBeDefined()
expect(Object.keys(view.viewHooks)).toEqual([])
})

test("createHook", (done) => {
Expand Down
Loading