Skip to content

(#204) Upgrade .Net 8 #289

(#204) Upgrade .Net 8

(#204) Upgrade .Net 8 #289

Triggered via push December 15, 2023 10:48
Status Success
Total duration 5m 9s
Artifacts 7
Fit to window
Zoom out
Zoom in

Annotations

11 warnings
build
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-dotnet@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
build: src/Monolith/ClassifiedAds.EndToEndTests/TestBase.cs#L31
Change TestBase.Dispose() to call GC.SuppressFinalize(object). This will prevent derived types that introduce a finalizer from needing to re-implement 'IDisposable' to call it. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1816)
build: src/Monolith/ClassifiedAds.CrossCuttingConcerns/Caching/ICache.cs#L11
Rename virtual/interface member ICache.Get(string) so that it no longer conflicts with the reserved language keyword 'Get'. Using a reserved keyword as the name of a virtual/interface member makes it harder for consumers in other languages to override/implement the member. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1716)
build: src/Monolith/ClassifiedAds.CrossCuttingConcerns/HtmlGenerator/IHtmlGenerator.cs#L7
In virtual/interface member IHtmlGenerator.GenerateAsync(string, object), rename parameter template so that it no longer conflicts with the reserved language keyword 'template'. Using a reserved keyword as the name of a parameter on a virtual/interface member makes it harder for consumers in other languages to override/implement the member. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1716)
build: src/Monolith/ClassifiedAds.CrossCuttingConcerns/ExtensionMethods/TypeExtensions.cs#L28
Prefer comparing 'Length' to 0 rather than using 'Any()', both for clarity and for performance (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1860)
build: src/Monolith/ClassifiedAds.CrossCuttingConcerns/ExtensionMethods/GuidExtensions.cs#L7
Identifier 'guid' contains type name (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1720)
build: src/Monolith/ClassifiedAds.CrossCuttingConcerns/ExtensionMethods/ObjectExtensions.cs#L10
Avoid creating a new 'JsonSerializerOptions' instance for every serialization operation. Cache and reuse instances instead. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1869)

Artifacts

Produced during runtime
Name Size
ClassifiedAds.BackgroundServer Expired
241 MB
ClassifiedAds.BlazorServerSide Expired
265 MB
ClassifiedAds.BlazorWebAssembly Expired
23.6 MB
ClassifiedAds.GraphQL Expired
240 MB
ClassifiedAds.Migrator Expired
243 MB
ClassifiedAds.WebAPI Expired
281 MB
ClassifiedAds.WebMVC Expired
276 MB