test: remove tests for SeriesSalesImportServiceImpl class

Part of #1668
php-coder · Mar 14, 2024 · 68030d2 · 68030d2
1 parent da0d240
commit 68030d2
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 157 deletions.
diff --git a/...main/java/ru/mystamps/web/feature/series/importing/sale/SeriesSalesImportServiceImpl.java b/...main/java/ru/mystamps/web/feature/series/importing/sale/SeriesSalesImportServiceImpl.java
@@ -39,7 +39,6 @@ public class SeriesSalesImportServiceImpl implements SeriesSalesImportService {
 	private final SiteParserService siteParserService;
 	private final SeriesInfoExtractorService extractorService;
 
-	// @todo #995 SeriesSalesImportServiceImpl.downloadAndParse(): add unit tests
 	@Override
 	@Transactional(readOnly = true)
 	@PreAuthorize(HasAuthority.IMPORT_SERIES)

diff --git a/...ovy/ru/mystamps/web/feature/series/importing/sale/SeriesSalesImportServiceImplTest.groovy b/...ovy/ru/mystamps/web/feature/series/importing/sale/SeriesSalesImportServiceImplTest.groovy
diff --git a/src/test/java/ru/mystamps/web/service/TestObjects.java b/src/test/java/ru/mystamps/web/service/TestObjects.java
@@ -24,17 +24,12 @@
 import ru.mystamps.web.feature.account.UsersActivationFullDto;
 import ru.mystamps.web.feature.image.ImageDto;
 import ru.mystamps.web.feature.image.ImageInfoDto;
-import ru.mystamps.web.feature.series.importing.sale.SeriesSaleParsedDataDto;
-import ru.mystamps.web.feature.series.importing.sale.SeriesSalesParsedDataDbDto;
 import ru.mystamps.web.feature.site.SuspiciousActivityDto;
 import ru.mystamps.web.tests.Random;
 
 import java.nio.charset.StandardCharsets;
 import java.util.Date;
 
-import static io.qala.datagen.RandomShortApi.bool;
-import static io.qala.datagen.RandomShortApi.nullOr;
-
 public final class TestObjects {
 	public static final String TEST_ACTIVITY_TYPE    = "EventType";
 	public static final String TEST_ACTIVITY_PAGE    = "http://example.org/some/page";
@@ -121,51 +116,4 @@ public static SuspiciousActivityDto createSuspiciousActivityDto() {
 		);
 	}
 
-	public static SeriesSalesParsedDataDbDto createSeriesSalesParsedDataDbDto() {
-		SeriesSalesParsedDataDbDto dto = new SeriesSalesParsedDataDbDto();
-
-		boolean existingSeller = bool();
-		if (existingSeller) {
-			dto.setSellerId(Random.id());
-		} else {
-			dto.setSellerName(Random.sellerName());
-			dto.setSellerUrl(Random.url());
-		}
-
-		dto.setPrice(Random.price());
-		dto.setCurrency(Random.currency().toString());
-		dto.setCreatedAt(Random.date());
-		dto.setUpdatedAt(Random.date());
-		return dto;
-	}
-
-	public static SeriesSaleParsedDataDto createSeriesSaleParsedDataDto() {
-		Integer sellerId = null;
-		Integer sellerGroupId = null;
-		String sellerName = null;
-		String sellerUrl = null;
-
-		boolean existingSeller = bool();
-		if (existingSeller) {
-			sellerId = Random.id();
-		} else {
-			sellerGroupId = Random.id();
-			sellerName = Random.sellerName();
-			sellerUrl = Random.url();
-		}
-
-		return new SeriesSaleParsedDataDto(
-			sellerId,
-			sellerGroupId,
-			sellerName,
-			sellerUrl,
-			Random.price(),
-			Random.currency(),
-			Random.price(),
-			// FIXME: alternative currency shouldn't match with currency
-			Random.currency(),
-			nullOr(Random.seriesCondition())
-		);
-	}
-
 }
diff --git a/src/test/java/ru/mystamps/web/tests/Random.java b/src/test/java/ru/mystamps/web/tests/Random.java
@@ -27,7 +27,6 @@
 import ru.mystamps.web.feature.country.CountryValidation;
 import ru.mystamps.web.feature.participant.ParticipantValidation;
 import ru.mystamps.web.feature.series.SeriesValidation;
-import ru.mystamps.web.feature.series.sale.SeriesCondition;
 import ru.mystamps.web.feature.site.SiteUrl;
 
 import java.math.BigDecimal;
@@ -101,10 +100,6 @@ public static Currency currency() {
 		return sample(Currency.values());
 	}
 
-	public static SeriesCondition seriesCondition() {
-		return sample(SeriesCondition.values());
-	}
-
 	public static String url() {
 		final long minLength = 5;
 		final long maxLength = 15;