Reduce number of unit tests #1668

php-coder · 2024-02-07T13:42:59Z

Check list:

Implement role testing with molecule #1145 needs a decision
will drastically reduce a scope of Migrate unit tests away from Spock to JUnit back #1246
check the current tests and remove non-usefull
- SlugUtilsTest.groovy
- LocaleUtilsTest.groovy
- PagerTest.groovy
- SeriesSalesServiceImplTest.groovy (resolution: fully remove)
- CatalogUtilsTest.groovy
- StampsCatalogServiceImplTest.groovy (resolution: fully remove)
- SeriesSalesImportServiceImplTest.groovy (resolution: fully remove)
- SeriesInfoExtractorServiceImplTest.groovy
- TimedSeriesInfoExtractorServiceTest.groovy (resolution: fully remove)
- SeriesImportServiceImplTest.groovy (resolution: remove most of the tests)
  - keep addRequest() should throw exception if url is incorrect
  - keep addRequest() should save url in the encoded form
  - keep addRequest() should not encode url if it is already encoded
- SeriesServiceImplTest.groovy (resolution: remove most of the tests)
  - keep add() should remove image when exception occurs
  - keep addImageToSeries() should remove image when exception occurs
- CollectionServiceImplTest.groovy (resolution: fully remove)
- CategoryServiceImplTest.groovy (resolution: fully remove)
- ParticipantServiceImplTest.groovy (resolution: fully remove)
- FilesystemImagePersistenceStrategyTest.groovy
- ImageServiceImplTest.groovy (resolution: remove most of the tests)
  - keep save() should pass content type '#contentType' to image dao (but rename it and emphasize testing of conversion logic)
  - keep save() should pass abbreviated filename when it is too long
- TimedImagePreviewStrategyTest.groovy (resolution: fully remove)
- DatabaseImagePersistenceStrategyTest.groovy
- SiteServiceImplTest.groovy (resolution: remove most of the tests)
  - keep logEvent() should pass abbreviated method when it's too long
  - keep logEvent() should pass abbreviated referer when it's too long
  - keep logEvent() should pass abbreviated user agent when it's too long
  - keep logAboutAbsentPage() should pass abbreviated page when it's too long
- CronServiceImplTest.groovy
- SuspiciousActivityServiceImplTest.groovy
- UsersActivationServiceImplTest.groovy
- UserServiceImplTest.groovy (resolution: fully remove)
- CountryServiceImplTest.groovy (resolution: fully remove)
- JsoupSiteParserTest.java
- JdbcCategoryDaoTest.java
- JdbcCountryDaoTest.java
- ContentSecurityPolicyHeaderWriterTest.java
remove unused methods from TestObjects, Random and DateUtils classes
close issues for adding more unit tests
remove comments like protected for using in unit tests

The text was updated successfully, but these errors were encountered:

The following issue won't be fixed: Closes #800 Closes #805 Part of #1668

The following issue won't be fixed: Closes #825 Closes #1629 Part of #1668

The following issue won't be fixed: Closes #827 Closes #1630 Part of #1668

The following issue won't be fixed: Closes #1194 Closes #1614 Part of #1668

Part of #1668

The following issue won't be fixed: Closes #579 Closes #1366 Part of #1668

Part of #1668

The following issue won't be fixed: Closes #1318 Closes #1373 Closes #1423 Closes #1433 Closes #1436 Part of #1668

The following issue won't be fixed: Closes #757 Closes #902 Closes #923 Closes #1271 Closes #1430 Part of #1668

Part of #1668

Should be in b7a4051 commit. Part of #1668

…reateAddToCollectionDto() methods Should be in 76894d6 commit. Part of #1668

Should be in b7a4051 commit. Part of #1668

Should be in 38a1263 commit. Part of #1668

Should be in b7a4051 commit. Part of #1668

Should be in 76894d6 commit. Part of #1668

…Dto() method Should be in 76894d6 commit. Part of #1668

Should be in 399cbbd commit. Part of #1668

Should be in 95bfe50 commit. Part of #1668

Should be in db5a330 commit. Part of #1668

Should be in db5a330 commit. The following issue won't be fixed: Closes #746 Part of #1668

Should be in b7a4051 commit. Part of #1668

Should be in 1d7c82d commit. The following issue won't be fixed: Closes #926 Part of #1668

Should be in 95bfe50 commit. Part of #1668

Should be in 1d7c82d commit. Part of #1668

…) methods Should be in b7a4051 commit. Part of #1668

Part of #1668

php-coder added area/unit tests ADR/needed A decision has been made and it needs to be documented labels Feb 7, 2024

php-coder added this to the 0.4.8 milestone Feb 9, 2024

php-coder self-assigned this Feb 27, 2024

php-coder added a commit that referenced this issue Feb 27, 2024

test: remove tests for Timed* classes

38a1263

The following issue won't be fixed: Closes #800 Closes #805 Part of #1668

php-coder added a commit that referenced this issue Feb 28, 2024

test: remove tests for CategoryServiceImpl class

399cbbd

The following issue won't be fixed: Closes #825 Closes #1629 Part of #1668

php-coder added a commit that referenced this issue Feb 28, 2024

test: remove tests for CountryServiceImpl class

95bfe50

The following issue won't be fixed: Closes #827 Closes #1630 Part of #1668

php-coder added a commit that referenced this issue Feb 28, 2024

test: remove tests for CollectionServiceImpl class

76894d6

The following issue won't be fixed: Closes #1194 Closes #1614 Part of #1668

php-coder added a commit that referenced this issue Feb 28, 2024

test: remove tests for ParticipantServiceImpl class

1d7c82d

Part of #1668

php-coder added a commit that referenced this issue Mar 6, 2024

test: remove most of the tests for ImageServiceImpl class

45129c3

The following issue won't be fixed: Closes #579 Closes #1366 Part of #1668

php-coder added a commit that referenced this issue Mar 6, 2024

test: remove most of the tests for SiteServiceImpl class

2463c74

Part of #1668

php-coder added a commit that referenced this issue Mar 6, 2024

test: remove most of the tests for SeriesServiceImpl class

b7a4051

The following issue won't be fixed: Closes #1318 Closes #1373 Closes #1423 Closes #1433 Closes #1436 Part of #1668

php-coder added a commit that referenced this issue Mar 6, 2024

test: remove most of the tests for SeriesImportServiceImpl class

db5a330

The following issue won't be fixed: Closes #757 Closes #902 Closes #923 Closes #1271 Closes #1430 Part of #1668

php-coder added a commit that referenced this issue Mar 13, 2024

test: remove tests for SeriesSalesServiceImpl class

96db597

Part of #1668

php-coder added a commit that referenced this issue Mar 13, 2024

refactor: remove unused TestObjects.createSitemapInfoDto() method

06d9de1

Should be in b7a4051 commit. Part of #1668

php-coder added a commit that referenced this issue Mar 13, 2024

refactor: remove unused TestObjects.createAddToCollectionForm() and c…

9614560

…reateAddToCollectionDto() methods Should be in 76894d6 commit. Part of #1668

php-coder added a commit that referenced this issue Mar 13, 2024

refactor: remove unused TestObjects.createSeriesLinkDto() method

0b7076a

Should be in b7a4051 commit. Part of #1668

php-coder added a commit that referenced this issue Mar 13, 2024

refactor: remove unused TestObjects.createRawParsedDataDto() method

79d7fbb

Should be in 38a1263 commit. Part of #1668

php-coder added a commit that referenced this issue Mar 13, 2024

refactor: remove unused TestObjects.createSeriesInGalleryDto() method

8a50b2a

Should be in b7a4051 commit. Part of #1668

php-coder added a commit that referenced this issue Mar 13, 2024

refactor: remove unused TestObjects.createSeriesFullInfoDto() method

d8a952a

Should be in b7a4051 commit. Part of #1668

php-coder added a commit that referenced this issue Mar 13, 2024

refactor: remove unused TestObjects.createCollectionInfoDto() method

7a6de5a

Should be in 76894d6 commit. Part of #1668

php-coder added a commit that referenced this issue Mar 13, 2024

refactor: remove unused TestObjects.createSeriesInCollectionWithPrice…

07023d0

…Dto() method Should be in 76894d6 commit. Part of #1668

php-coder added a commit that referenced this issue Mar 13, 2024

refactor: remove unused Random.categorySlug() method

d74078e

Should be in 399cbbd commit. Part of #1668

php-coder added a commit that referenced this issue Mar 13, 2024

refactor: remove unused Random.countrySlug() method

61f7e73

Should be in 95bfe50 commit. Part of #1668

php-coder added a commit that referenced this issue Mar 13, 2024

refactor: remove unused Random.importRequestStatuses() method

2dc626b

Should be in db5a330 commit. Part of #1668

php-coder added a commit that referenced this issue Mar 13, 2024

refactor: remove unused TestObjects.listOfImportRequestFullInfo() method

0bc9d1b

Should be in db5a330 commit. The following issue won't be fixed: Closes #746 Part of #1668

php-coder added a commit that referenced this issue Mar 13, 2024

refactor: remove unused Random.listOfSeriesInfoDto() method

c10249b

Should be in b7a4051 commit. Part of #1668

php-coder added a commit that referenced this issue Mar 13, 2024

refactor: remove unused Random.listOfEntityWithParentDto() method

54b9e60

Should be in 1d7c82d commit. The following issue won't be fixed: Closes #926 Part of #1668

php-coder added a commit that referenced this issue Mar 13, 2024

refactor: remove unused Random.listOfStrings() method

da92420

Should be in 95bfe50 commit. Part of #1668

php-coder added a commit that referenced this issue Mar 13, 2024

refactor: remove unused Random.listOfEntityWithIdDto() method

1d80604

Should be in 1d7c82d commit. Part of #1668

php-coder added a commit that referenced this issue Mar 13, 2024

refactor: remove unused Random.solovyovNumbers() and zagorskiNumbers(…

17eaee0

…) methods Should be in b7a4051 commit. Part of #1668

php-coder added a commit that referenced this issue Mar 14, 2024

test: remove tests for StampsCatalogServiceImpl class

da0d240

Part of #1668

php-coder added a commit that referenced this issue Mar 14, 2024

test: remove tests for SeriesSalesImportServiceImpl class

68030d2

Part of #1668

php-coder added a commit that referenced this issue Mar 14, 2024

test: remove tests for UserServiceImplTest class

df1e698

Part of #1668

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reduce number of unit tests #1668

Reduce number of unit tests #1668

php-coder commented Feb 7, 2024 •

edited

Loading

Reduce number of unit tests #1668

Reduce number of unit tests #1668

Comments

php-coder commented Feb 7, 2024 • edited Loading

Check list:

php-coder commented Feb 7, 2024 •

edited

Loading