Don't send attributes if it's empty

php-enqueue · Jul 12, 2024 · 8495deb · 8495deb
1 parent 46929e0
commit 8495deb
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/pkg/gps/GpsProducer.php b/pkg/gps/GpsProducer.php
@@ -37,10 +37,14 @@ public function send(Destination $destination, Message $message): void
 
         /** @var Topic $topic */
         $topic = $this->context->getClient()->topic($destination->getTopicName());
-        $topic->publish([
-            'data' => json_encode($message),
-            'attributes' => $message->getAttributes(),
-        ]);
+
+        $params = ['data' => json_encode($message)];
+
+        if (count($message->getAttributes()) > 0) {
+            $params['attributes'] = $message->getAttributes();
+        }
+
+        $topic->publish($params);
     }
 
     public function setDeliveryDelay(?int $deliveryDelay = null): Producer

diff --git a/pkg/gps/Tests/GpsProducerTest.php b/pkg/gps/Tests/GpsProducerTest.php
@@ -35,7 +35,6 @@ public function testShouldSendMessage()
             ->method('publish')
             ->with($this->identicalTo([
                 'data' => '{"body":"","properties":[],"headers":[]}',
-                'attributes' => [],
             ])
             );