Updated phpunit config + fixed phpstan errors

php-etl · Nov 22, 2023 · 19f6009 · 19f6009
1 parent 87169db
commit 19f6009
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 34 deletions.
diff --git a/phpunit.xml b/phpunit.xml
@@ -1,33 +1,18 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <!-- https://phpunit.de/manual/current/en/appendixes.configuration.html -->
-<phpunit
-        xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-        xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.0/phpunit.xsd"
-        backupGlobals="true"
-        colors="false"
-        processIsolation="false"
-        stopOnError="false"
-        stopOnFailure="false"
-        stopOnIncomplete="false"
-        stopOnSkipped="false"
-        stopOnRisky="false"
-        timeoutForSmallTests="1"
-        timeoutForMediumTests="10"
-        timeoutForLargeTests="60"
-        cacheDirectory=".phpunit.cache"
-        backupStaticProperties="false"
-        requireCoverageMetadata="false">
-    <testsuites>
-        <testsuite name="Functional tests">
-            <directory>tests/functional/</directory>
-        </testsuite>
-    </testsuites>
-    <coverage>
-        <include>
-            <directory suffix=".php">src</directory>
-        </include>
-    </coverage>
-    <php>
-        <ini name="allow_url_include" value="1"/>
-    </php>
+<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.4/phpunit.xsd" backupGlobals="true" colors="false" processIsolation="false" stopOnError="false" stopOnFailure="false" stopOnIncomplete="false" stopOnSkipped="false" stopOnRisky="false" timeoutForSmallTests="1" timeoutForMediumTests="10" timeoutForLargeTests="60" cacheDirectory=".phpunit.cache" backupStaticProperties="false" requireCoverageMetadata="false">
+  <testsuites>
+    <testsuite name="Functional tests">
+      <directory>tests/functional/</directory>
+    </testsuite>
+  </testsuites>
+  <coverage/>
+  <php>
+    <ini name="allow_url_include" value="1"/>
+  </php>
+  <source>
+    <include>
+      <directory suffix=".php">src</directory>
+    </include>
+  </source>
 </phpunit>
diff --git a/src/FingersCrossed/Extractor.php b/src/FingersCrossed/Extractor.php
@@ -22,8 +22,7 @@ public function __construct(
         private string $escape = '\\',
         private ?array $columns = null,
         private LoggerInterface $logger = new NullLogger()
-    ) {
-    }
+    ) {}
 
     /** @return iterable<AcceptanceResultBucket<array>|RejectionResultBucket<array|null>> */
     public function extract(): iterable

diff --git a/src/Safe/Extractor.php b/src/Safe/Extractor.php
@@ -23,8 +23,7 @@ public function __construct(
         private string $escape = '\\',
         private ?array $columns = null,
         private LoggerInterface $logger = new NullLogger()
-    ) {
-    }
+    ) {}
 
     /** @return ResultBucketInterface[] */
     public function extract(): iterable