Merge pull request #144 from php-etl/fix/code-issues

Added the ability to add code to a job in a workflow

composer.json

@@ -31,7 +31,7 @@
         "php-etl/packaging": "*",
         "php-etl/configurator-contracts": "0.8.*",
         "php-etl/satellite-toolbox": "*",
-        "php-etl/gyroscops-api-client": "*",
+        "php-etl/gyroscops-api-client": "^0.3.0",
         "php-etl/dockerfile": "*",
         "composer/composer": "*",
         "symfony/deprecation-contracts": "*",

rector.php

@@ -4,6 +4,7 @@
 
 use Rector\CodeQuality\Rector\Class_\InlineConstructorDefaultToPropertyRector;
 use Rector\Config\RectorConfig;
+use Rector\Php55\Rector\String_\StringClassNameToClassConstantRector;
 use Rector\Set\ValueObject\LevelSetList;
 use Rector\PHPUnit\Set\PHPUnitLevelSetList;
 use Rector\Symfony\Set\SymfonyLevelSetList;
@@ -20,4 +21,8 @@
         PHPUnitLevelSetList::UP_TO_PHPUNIT_100,
         SymfonyLevelSetList::UP_TO_SYMFONY_60,
     ]);
+
+    $rectorConfig->skip([
+        StringClassNameToClassConstantRector::class
+    ]);
 };

src/Action/Action.php

@@ -15,7 +15,9 @@
 
 final readonly class Action
 {
-    public function __construct(private ?string $plugin, private ExpressionLanguage $interpreter = new Satellite\ExpressionLanguage()) {}
+    public function __construct(private ?string $plugin, private ExpressionLanguage $interpreter = new Satellite\ExpressionLanguage())
+    {
+    }
 
     public function __invoke(array $config, ActionBuilder $action, RepositoryInterface $repository): void
     {
@@ -43,7 +45,7 @@ public function __invoke(array $config, ActionBuilder $action, RepositoryInterfa
             $state = $compiled->getBuilder()->getNode();
         } else {
             $state = new Node\Expr\New_(
-                new Node\Name\FullyQualified(\Kiboko\Contract\Action\NullState::class),
+                new Node\Name\FullyQualified('Kiboko\\Contract\\Action\\NullState'),
             );
         }
 

src/Action/ConfigurationApplier.php

@@ -17,7 +17,8 @@ public function __construct(
         private readonly string $plugin,
         private readonly FactoryInterface $service,
         private readonly ExpressionLanguage $interpreter,
-    ) {}
+    ) {
+    }
 
     public function withAction(): self
     {

src/Action/Custom/Builder/Action.php

@@ -12,7 +12,9 @@ final class Action implements ActionBuilderInterface
     private ?Node\Expr $logger = null;
     private ?Node\Expr $state = null;
 
-    public function __construct(private readonly Node\Expr $service, private readonly string $containerNamespace) {}
+    public function __construct(private readonly Node\Expr $service, private readonly string $containerNamespace)
+    {
+    }
 
     public function withLogger(Node\Expr $logger): self
     {

src/Action/Custom/Factory/Action.php

@@ -44,7 +44,7 @@ public function normalize(array $config): array
     {
         try {
             return $this->processor->processConfiguration($this->configuration, $config);
-        } catch (Symfony\InvalidTypeException|Symfony\InvalidConfigurationException $exception) {
+        } catch (Symfony\InvalidConfigurationException|Symfony\InvalidTypeException $exception) {
             throw new Configurator\InvalidConfigurationException($exception->getMessage(), 0, $exception);
         }
     }
@@ -55,7 +55,7 @@ public function validate(array $config): bool
             $this->processor->processConfiguration($this->configuration, $config);
 
             return true;
-        } catch (Symfony\InvalidTypeException|Symfony\InvalidConfigurationException) {
+        } catch (Symfony\InvalidConfigurationException|Symfony\InvalidTypeException) {
             return false;
         }
     }

src/Action/Custom/Factory/Repository/RepositoryTrait.php

@@ -14,7 +14,7 @@ trait RepositoryTrait
     /** @var string[] */
     private array $packages;
 
-    public function addFiles(Packaging\FileInterface|Packaging\DirectoryInterface ...$files): Configurator\RepositoryInterface
+    public function addFiles(Packaging\DirectoryInterface|Packaging\FileInterface ...$files): Configurator\RepositoryInterface
     {
         array_push($this->files, ...$files);