Skip to content

array offset (level, message, context) should not be guarantee for hasRecord() #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

array offset (level, message, context) should not be guarantee for hasRecord() #19

wants to merge 1 commit into from
+10 −9

Conversation

@sasezaki
Copy link
Contributor

fix #18

@sasezaki sasezaki mentioned this pull request Oct 29, 2025
Open
@sasezaki sasezaki changed the title array offset should not be guarantee for hasRecord() array offset (level, message, context) should not be guarantee for hasRecord() Oct 29, 2025
@sasezaki sasezaki mentioned this pull request Oct 31, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@mbabker mbabker mbabker approved these changes

@derrabus derrabus derrabus approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

level key of log_record_array Psalm type causes SA issues in TestLogger::has*() methods

3 participants

@sasezaki @mbabker @derrabus