Skip to content

Conversation

@sasezaki
Copy link
Contributor

At #15, introduced array shape context: array{exception?: \Throwable}.
But I missed asserting for this.

Regarding #17, I'm wondering if I should change it to context: array<array-key, mixed>

@derrabus
Copy link

The assertion you're proposing would be off-spec, as the specification does not forbid storing non-throwables under the exception key. Your application could chose to convert an exception into an array before logging it or even store something completely different there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants