Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some deprecations #440

Merged
merged 1 commit into from
Nov 21, 2023
Merged

fix some deprecations #440

merged 1 commit into from
Nov 21, 2023

Conversation

dbu
Copy link
Collaborator

@dbu dbu commented Nov 18, 2023

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets -
Documentation -
License MIT

What's in this PR?

Fix deprecation issues with the php-http/message repository.

@dbu dbu force-pushed the fix-deprecations branch 4 times, most recently from 499a746 to 4ee18de Compare November 18, 2023 18:35
@ostrolucky
Copy link
Collaborator

lot of test failures, are they related?

@dbu dbu force-pushed the fix-deprecations branch from 4ee18de to 46b305a Compare November 19, 2023 07:30
@dbu dbu force-pushed the fix-deprecations branch from 46b305a to cec50f6 Compare November 19, 2023 07:33
@dbu
Copy link
Collaborator Author

dbu commented Nov 19, 2023

lot of test failures, are they related?

we had too much mocking in the unit tests. i reduced that quite a bit but messed up in a few places. now it should be fixed.
glad if you want to review if it all makes sense.

@dbu dbu merged commit 1b16d97 into 1.x Nov 21, 2023
12 checks passed
@dbu dbu deleted the fix-deprecations branch November 21, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants