-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AddHostPlugin must also handle the port #29
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,10 @@ | ||
# Change Log | ||
|
||
## Unreleased | ||
|
||
### Changed | ||
|
||
- AddHostPlugin also sets the port if specified | ||
|
||
## 1.2.0 - 2016-07-14 | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,7 +8,7 @@ | |
use Symfony\Component\OptionsResolver\OptionsResolver; | ||
|
||
/** | ||
* Add schema and host to a request. Can be set to overwrite the schema and host if desired. | ||
* Add schema, host and port to a request. Can be set to overwrite the schema and host if desired. | ||
* | ||
* @author Tobias Nyholm <[email protected]> | ||
*/ | ||
|
@@ -52,8 +52,11 @@ public function __construct(UriInterface $host, array $config = []) | |
public function handleRequest(RequestInterface $request, callable $next, callable $first) | ||
{ | ||
if ($this->replace || $request->getUri()->getHost() === '') { | ||
$uri = $request->getUri()->withHost($this->host->getHost()); | ||
$uri = $uri->withScheme($this->host->getScheme()); | ||
$uri = $request->getUri() | ||
->withHost($this->host->getHost()) | ||
->withScheme($this->host->getScheme()) | ||
->withPort($this->host->getPort()) | ||
; | ||
|
||
$request = $request->withUri($uri); | ||
} | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
according to the PSR interface, getPort should return null if its the default port for this protocol, and
withPort(null)
must remove the port so that the default port is used. with a very poor uri implementation, this could lead to changing http://localhost/ to http://localhost:80/ which is a bit ugly but not wrong. i prefer that over complicated logic in here to detect the default port ourselves.we must set the port to null if it is null, for the case of
replace
, as the original request could have specified a different port.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, we should assume that the PSR-7 implementation follows PSR7, even though it is weird at some places.