Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added code example of how to use message factories #130

Merged
merged 3 commits into from
Aug 2, 2016

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Jul 28, 2016

Related to #14 but it will not fix all of it

$request = $factory->createRequest('GET', 'http://example.com');


.. _Diactoros: http://docs.guzzlephp.org/en/5.3/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this the correct link. searching for "Diactoros" on the linked page finds nothing. shouldn't this link to something zend framework?

Copy link
Member Author

@Nyholm Nyholm Aug 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a copy-paste error.

#129

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah. can you rebase and fix this?

@Nyholm
Copy link
Member Author

Nyholm commented Aug 2, 2016

The PR is updated

@dbu dbu merged commit 0a08c07 into php-http:master Aug 2, 2016
@Nyholm Nyholm deleted the message-factories branch August 2, 2016 15:50
@Nyholm
Copy link
Member Author

Nyholm commented Aug 2, 2016

Thank you for merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants