refactor: add extension point to payload contract handling #301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chr-hertel
commented
May 4, 2025
There was a problem hiding this comment.
this shouldn't be needed - would be easier if we do it directly in ModelClient, like before
chr-hertel
commented
May 4, 2025
chr-hertel
commented
May 4, 2025
Comment on lines
-16
to
+13
| public function supports(Model $model, array|string|object $input): bool; | ||
| public function supports(Model $model): bool; |
chr-hertel
commented
May 4, 2025
src/Platform/Contract.php
Outdated
There was a problem hiding this comment.
questionable instance handling, would be great tho to decouple from globale NormalizerInterface
chr-hertel
force-pushed
the
refactor-contract-handling
branch
from
591474f to
c6ba1ce
Compare
OskarStark
reviewed
May 5, 2025
Comment on lines
+18
to
+23
| public function registerTypes(): array | ||
| { | ||
| return [ | ||
| 'string' => 'handleInput', | ||
| ]; | ||
| } |
There was a problem hiding this comment.
couldn't we do this using an attribute like the event listeners do?
OskarStark
reviewed
May 5, 2025
| ]; | ||
| } | ||
|
|
||
| public function handleInput(string $input): array |
There was a problem hiding this comment.
Suggested change
| public function handleInput(string $input): array | |
| #[AsExtension('string')] | |
| public function handleInput(string $input): array |
idea
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to address pain of #291 and #297