Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the fix up for
refsect1
to<title>_</title><simpara>%failed xi:xinclude%</simpara>
. As this cannot be parsed as an XML document, code is also changed to support fix ups that are XML fragments.This PR, php/doc-it#55 and
doc-en
patch below fixesdoc-it
building.Two notes:
<xi:fallback>
from sources, as the automatic fixups can push/keep translations into building state.The fixup
<title></title><simpara>%failed xi:xinclude%</simpara>
(empty title) is saved on.manual.xml
as:and is rendered by
php phd/render.php --format bigxhtml
as:Instead of:
In other words, empty
<title>
causes their siblings to be rendered inside the title, instead of around it.To workaround this, and to avoid rendering
%failed xi:xinclude%
as big as titles, I placed an_
inside de title.I'm not so certain about
%failed xi:xinclude%
/_
. Another alternative was to keep these elements empty, so XInclude failures does not inject warnings in rendered manuals, and would like comments about this.