Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document xml:id usage #216

Merged
merged 2 commits into from
Feb 3, 2025
Merged

Document xml:id usage #216

merged 2 commits into from
Feb 3, 2025

Conversation

alfsb
Copy link
Member

@alfsb alfsb commented Jan 29, 2025

Make text more detailed and explicit, and also document what configure.php does in case of xml:id duplications.

docs/structure.md Outdated Show resolved Hide resolved
docs/structure.md Outdated Show resolved Hide resolved
docs/structure.md Show resolved Hide resolved
@alfsb
Copy link
Member Author

alfsb commented Jan 29, 2025

Thanks for approval. The failings on CI are unrelated, but I will wait some days before merging, hoping for a better picture in the meantime.

Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MSTM.

@alfsb alfsb merged commit 07b4806 into php:master Feb 3, 2025
8 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants