Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pcntl php84 #4073

Merged
merged 1 commit into from
Nov 17, 2024
Merged

Pcntl php84 #4073

merged 1 commit into from
Nov 17, 2024

Conversation

devnexen
Copy link
Member

No description provided.

@devnexen devnexen added this to the PHP 8.4 milestone Nov 15, 2024
@devnexen
Copy link
Member Author

for #3872

@devnexen devnexen requested a review from Girgias November 15, 2024 11:26
Comment on lines 1529 to 1579
<variablelist xml:id="constant.pcntl-qosclass.constants" role="constant_list">
<title>QosClass constants</title>
<varlistentry xml:id="constant.background">
<term>
<constant>Pcntl::Background</constant>
(<type>enum</type>)
</term>
<listitem>
<simpara>
Runs the process after all high-priority ones had ran their courses.
Available as of PHP 8.4.0 (macOs only).
</simpara>
</listitem>
</varlistentry>
<varlistentry xml:id="constant.default">
<term>
<constant>Pcntl::Default</constant>
(<type>enum</type>)
</term>
<listitem>
<simpara>
Runs the process after all high-priority processes but before the low-priority ones.
Available as of PHP 8.4.0 (macOs only).
</simpara>
</listitem>
</varlistentry>
<varlistentry xml:id="constant.user-interactive">
<term>
<constant>Pcntl::UserInteractive</constant>
(<type>enum</type>)
</term>
<listitem>
<simpara>
Runs the process as the highest priority level.
Available as of PHP 8.4.0 (macOs only).
</simpara>
</listitem>
</varlistentry>
<varlistentry xml:id="constant.user-initiated">
<term>
<constant>Pcntl::UserInitiated</constant>
(<type>enum</type>)
</term>
<listitem>
<simpara>
Runs the process at high priority level but below Pcntl::UserInteractive ones.
Available as of PHP 8.4.0 (macOs only).
</simpara>
</listitem>
</varlistentry>
</variablelist>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an enum, so it should not be documented here actually see #4080 for how such a page should look (albeit we don't have rendering support yet).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I expected you would ask me changes, kept it as a separate commit. Ok will have a look.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge the first commit then :)

@devnexen devnexen merged commit 71fa455 into php:master Nov 17, 2024
2 checks passed
@devnexen devnexen deleted the pcntl_php84 branch November 17, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants